Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

respect PodCIDR of node #78

Closed
wants to merge 1 commit into from
Closed

respect PodCIDR of node #78

wants to merge 1 commit into from

Conversation

carlory
Copy link
Member

@carlory carlory commented Nov 22, 2022 •
edited by wzshiming
Loading

Fixes #17

/kind feature

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 22, 2022
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 22, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @carlory. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 22, 2022
@carlory
Copy link
Member Author

carlory commented Nov 22, 2022

@wzshiming how to join the org? I'm a kubernetes member. kubernetes/org#2402

Can you give me some guide?

@wzshiming
Copy link
Member

@wzshiming how to join the org? I'm a kubernetes member. kubernetes/org#2402

Can you give me some guide?

If you are already a member of kubernetes, just submit an issue to kubernetes/org to apply for membership in kubernetes-sigs without any additional requirements

@wzshiming
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 23, 2022
wzshiming
wzshiming requested changes Nov 23, 2022
View reviewed changes
pkg/kwok/controllers/pod_controller.go Outdated Show resolved Hide resolved
pkg/kwok/controllers/pod_controller_test.go Outdated Show resolved Hide resolved
@carlory
Copy link
Member Author

carlory commented Nov 24, 2022

/test pull-kwok-unit-test-main

@carlory carlory mentioned this pull request Nov 25, 2022
Merged
wzshiming
wzshiming requested changes Nov 28, 2022
View reviewed changes
pkg/kwok/controllers/pod_controller.go Show resolved Hide resolved
pkg/kwok/controllers/utils.go
@@ -160,43 +168,71 @@ func (p *parallelTasks) Wait() {
p.wg.Wait()
}

type stringSets struct {
// nodeInfo holds information about a node
type nodeInfo struct {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
type nodeInfo struct {
type NodeInfo struct {

@k8s-ci-robot
Copy link
Contributor

@carlory: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 28, 2022
@carlory @wzshiming
respect PodCIDR of node
9002696 
Co-authored-by: Shiming Zhang <wzshiming@foxmail.com>
@netlify
Copy link

netlify bot commented Feb 10, 2023 •
edited
Loading

❌ Deploy Preview for k8s-kwok failed.

Name Link
🔨 Latest commit 9002696
🔍 Latest deploy log https://app.netlify.com/sites/k8s-kwok/deploys/63e5e3dbd92449000848b1b7

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: carlory
Once this PR has been reviewed and has the lgtm label, please assign huang-wei for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

@carlory: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kwok-unit-test-main 9002696 link true /test pull-kwok-unit-test-main
pull-kwok-e2e-test-main 9002696 link true /test pull-kwok-e2e-test-main
pull-kwok-build-main 9002696 link true /test pull-kwok-build-main
pull-kwok-verify-main 9002696 link true /test pull-kwok-verify-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wzshiming wzshiming mentioned this pull request Feb 20, 2023
Closed
@carlory carlory closed this Mar 8, 2023
@dewijones92 dewijones92 mentioned this pull request May 5, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wzshiming wzshiming wzshiming requested changes

@Huang-Wei Huang-Wei Awaiting requested review from Huang-Wei

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[kwok] Respect PodCIDR of Node
3 participants
@carlory @k8s-ci-robot @wzshiming