Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default of restart policy to RecreateGroupOnPodRestart #204

Closed
3 tasks
Tracked by #161
ahg-g opened this issue Aug 31, 2024 · 6 comments · Fixed by #214
Closed
3 tasks
Tracked by #161

Change default of restart policy to RecreateGroupOnPodRestart #204

ahg-g opened this issue Aug 31, 2024 · 6 comments · Fixed by #214
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@ahg-g
Copy link
Contributor

ahg-g commented Aug 31, 2024

What would you like to be added:

Change default of restart policy to RecreateGroupOnPodRestart.

Why is this needed:

It will be the most commonly used restart policy.

Completion requirements:

This enhancement requires the following artifacts:

  • Design doc
  • API change
  • Docs update

The artifacts should be linked in subsequent comments.

@ahg-g ahg-g added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 31, 2024
@vivianrwu
Copy link

/assign

@kerthcet
Copy link
Contributor

We should change the name as well, or Default policy but not default, and default is somehow unclear, default for what? Maybe None, which means the lws will not do anything, it's all the pod behavior.

@ahg-g
Copy link
Contributor Author

ahg-g commented Sep 12, 2024

hmm, unfortunately we can't remove it, but perhaps we can add a None value and in the webhook we re-write anything that sets Default to None.

@liurupeng liurupeng assigned kerthcet and unassigned vivianrwu Sep 12, 2024
@kerthcet
Copy link
Contributor

For backwards compatibility? We can mark it as deprecated and remove that in the future.

@ahg-g
Copy link
Contributor Author

ahg-g commented Sep 13, 2024

Sounds good, do you have time to do this?

@kerthcet
Copy link
Contributor

on the way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants