Deprecated DefaultRestartPolicy with NoneRestartPolicy #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kerthcet <kerthcet@gmail.com>
k8s-ci-robot
added
kind/feature
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kerthcet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
|
@ahg-g maybe you're online. |
ahg-g
reviewed
Sep 13, 2024
Comment on lines
260
to
264
| // DefaultRestartPolicy will recreate all the pods in the group if | ||
| // 1. Any individual pod in the group is recreated; 2. Any containers/init-containers | ||
| // in a pod is restarted. This is to ensure all pods/containers in the group will be | ||
| // started in the same time. | ||
| RecreateGroupOnPodRestart RestartPolicyType = "RecreateGroupOnPodRestart" | ||
| DefaultRestartPolicy RestartPolicyType = "RecreateGroupOnPodRestart" |
There was a problem hiding this comment.
Lets keep the parameter name as is and just add a comment that this is the default value.
Signed-off-by: kerthcet <kerthcet@gmail.com>
kerthcet
force-pushed
the
cleanup/add-none-policy
branch
from
1b9e7b7 to
b3a8977
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
/kind cleanup
What this PR does / why we need it
Which issue(s) this PR fixes
Fixes #204
Special notes for your reviewer
Does this PR introduce a user-facing change?