Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add event recorder event for lws controller #101

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

googs1025
Copy link
Member

@googs1025 googs1025 commented Apr 12, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it

  • add event for lws controller

I have only added an event recorder for the LWS controller and did not add any events for the pod controller. This decision was made because I believe that users will only be interested in events generated by the LWS controller and not those generated by the pod controller.
If there is a need to add events for the pod controller, please let me know and I will add them accordingly.

Which issue(s) this PR fixes

refer to: #100

Special notes for your reviewer

Does this PR introduce a user-facing change?

None

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 12, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 12, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @googs1025. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 12, 2024
@googs1025 googs1025 force-pushed the add_controller_event branch from d8d0f19 to 2c60315 Compare April 12, 2024 14:59
@googs1025 googs1025 force-pushed the add_controller_event branch from 2c60315 to 8bc2da4 Compare April 12, 2024 23:54
@liurupeng
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 12, 2024
@liurupeng
Copy link
Collaborator

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 12, 2024
@googs1025
Copy link
Member Author

/retest

@googs1025
Copy link
Member Author

/test pull-lws-test-integration-main

1 similar comment
@googs1025
Copy link
Member Author

/test pull-lws-test-integration-main

@googs1025
Copy link
Member Author

@liurupeng @kerthcet When I was running the CI, I noticed that errors were occurring, which was not expected. It seems like there might be some issues in the code. I feel like adding the event recorder alone shouldn't cause this error.

@googs1025
Copy link
Member Author

Wait for a while and check again. There haven't been any error messages.

@liurupeng
Copy link
Collaborator

liurupeng commented Apr 15, 2024

/approve
/lgtm

@liurupeng
Copy link
Collaborator

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: googs1025, liurupeng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2024
@googs1025
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit c8e201e into kubernetes-sigs:main Apr 16, 2024
7 checks passed
@kerthcet kerthcet mentioned this pull request Apr 16, 2024
@kerthcet
Copy link
Contributor

/retest

Please don't retest if you have a flaky, will lead to the code baseline unstable.

@@ -90,22 +91,26 @@ func (r *LeaderWorkerSetReconciler) Reconcile(ctx context.Context, req ctrl.Requ

partition, err := r.rollingUpdatePartition(ctx, lws)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think these events make sense to the system, event usually generated for state transitions, or specific reasons for diagnosis, not logging.

Please revert them. The only one makes sense to me is the createHeadlessService failed event, which is an important signal.

No need to created a new file to container the constants, they're not shared, located at this file is enough.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, i fix it right now

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline, hope to have a event to tell us that the rolling update is failed but there's no specific signal indicates the rolling update is failed. So maybe keep the same as sts right now.(Sts doesn't have a event to report that the rolling update is failed as well.)

Fix me if not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants