-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add event recorder event for lws controller #101
feat: add event recorder event for lws controller #101
Conversation
Hi @googs1025. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
d8d0f19
to
2c60315
Compare
2c60315
to
8bc2da4
Compare
/ok-to-test |
/lgtm |
/retest |
/test pull-lws-test-integration-main |
1 similar comment
/test pull-lws-test-integration-main |
@liurupeng @kerthcet When I was running the CI, I noticed that errors were occurring, which was not expected. It seems like there might be some issues in the code. I feel like adding the event recorder alone shouldn't cause this error. |
Wait for a while and check again. There haven't been any error messages. |
/approve |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: googs1025, liurupeng The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Please don't retest if you have a flaky, will lead to the code baseline unstable. |
@@ -90,22 +91,26 @@ func (r *LeaderWorkerSetReconciler) Reconcile(ctx context.Context, req ctrl.Requ | |||
|
|||
partition, err := r.rollingUpdatePartition(ctx, lws) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think these events make sense to the system, event usually generated for state transitions, or specific reasons for diagnosis, not logging.
Please revert them. The only one makes sense to me is the createHeadlessService
failed event, which is an important signal.
No need to created a new file to container the constants, they're not shared, located at this file is enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, i fix it right now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed offline, hope to have a event to tell us that the rolling update is failed but there's no specific signal indicates the rolling update is failed. So maybe keep the same as sts right now.(Sts doesn't have a event to report that the rolling update is failed as well.)
Fix me if not.
What type of PR is this?
/kind feature
What this PR does / why we need it
I have only added an event recorder for the LWS controller and did not add any events for the pod controller. This decision was made because I believe that users will only be interested in events generated by the LWS controller and not those generated by the pod controller.
If there is a need to add events for the pod controller, please let me know and I will add them accordingly.
Which issue(s) this PR fixes
refer to: #100
Special notes for your reviewer
Does this PR introduce a user-facing change?