Change the semantics of leaderWorkerSet Replicas #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
Signed-off-by: kerthcet <kerthcet@gmail.com>
Signed-off-by: kerthcet <kerthcet@gmail.com>
kerthcet
force-pushed
the
fix/updatedReplicas
branch
from
a10cf6b to
cf3cf26
Compare
ahg-g
reviewed
Apr 18, 2024
There was a problem hiding this comment.
Thanks! can we please update the documentation at https://github.com/kubernetes-sigs/lws/blob/main/api/leaderworkerset/v1/leaderworkerset_types.go#L179-L185?
// Replicas tracks the total number of groups currently created (updated or not, ready or not).
Replicas int32 `json:"replicas,omitempty"`
// ReadyReplicas tracks the number of groups that are in ready state (updated or not).
ReadyReplicas int32 `json:"readyReplicas,omitempty"`
// UpdatedReplicas tracks the number of groups that have been updated (ready or not).
UpdatedReplicas int32 `json:"updatedReplicas,omitempty"`
|
Thanks, looks good overall, I will continue the 0.2.0 release after this PR is merged. |
Signed-off-by: kerthcet <kerthcet@gmail.com>
kerthcet
force-pushed
the
fix/updatedReplicas
branch
from
5081253 to
83af7f7
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kerthcet, liurupeng The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it
Which issue(s) this PR fixes
Fixes #96 (comment)
Special notes for your reviewer
Does this PR introduce a user-facing change?