Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add verify job and fix code where it fails #180

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

kannon92
Copy link
Contributor

@kannon92 kannon92 commented Jul 26, 2024

What type of PR is this?

/kind ci

What this PR does / why we need it

Add a make verify job that runs the linter and checks the TOC for keps.

Linter is important to catch problems.

Which issue(s) this PR fixes

Fixes #178

Special notes for your reviewer

We need a test-infra job to actually run make verify. kubernetes/test-infra#33122 can be used to verify the linter job before merge.

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot
Copy link
Contributor

@kannon92: The label(s) kind/ci cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind ci

What this PR does / why we need it

Add a make verify job that runs the linter and checks the TOC for keps.

Linter is important to catch problems.

Which issue(s) this PR fixes

Fixes #178

Special notes for your reviewer

We need a test-infra job to actually run make verify. I will have that up shortly and we merge that to verify that this job in fact works.

Does this PR introduce a user-facing change?

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 26, 2024
@k8s-ci-robot k8s-ci-robot requested review from ahg-g and liurupeng July 26, 2024 21:12
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 26, 2024
@liurupeng
Copy link
Collaborator

thanks! @kannon92

@liurupeng
Copy link
Collaborator

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 29, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kannon92, liurupeng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2024
@k8s-ci-robot k8s-ci-robot merged commit f01a24d into kubernetes-sigs:main Jul 29, 2024
8 checks passed
@kannon92
Copy link
Contributor Author

Can you also approve kubernetes/test-infra#33122?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LWS should have a verify job to check lint and toc.
3 participants