Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make llama.cpp example become avaliable on macOS #211

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

carlory
Copy link
Member

@carlory carlory commented Sep 9, 2024

What type of PR is this?

/kind bug

What this PR does / why we need it

  • curl -v -L --fail -o Meta-Llama-3-8B-Instruct-Q5_K_M.gguf http://$(ip -4 route show default | awk '/default/ { print $3 }'):9999/16d824ee771e0e33b762bb3dc3232b972ac8dce4d2d449128fca5081962a1a9e; \ can not find the correct host IP when I run script on macOS
  • the --exact option is unavailable on macOS

Test result:

(base) ➜  llamacpp git:(main) ✗ dev/tasks/run-in-kind
...
#23 [bartowski quantizer 5/6] RUN if [ -n "10.64.0.228" ]; then     curl -v -L --fail -o Meta-Llama-3-8B-Instruct-Q5_K_M.gguf http://10.64.0.228:9999/16d824ee771e0e33b762bb3dc3232b972ac8dce4d2d449128fca5081962a1a9e;   else     curl -v -L --fail -o Meta-Llama-3-8B-Instruct-Q5_K_M.gguf http://$(ip -4 route show default | awk '/default/ { print $3 }'):9999/16d824ee771e0e33b762bb3dc3232b972ac8dce4d2d449128fca5081962a1a9e;   fi
 24 5467M   24 1317M    0     0  6518k      0  0:14:18  0:03:26  0:10:52 1393k
...
leaderworkerset.leaderworkerset.x-k8s.io/llamacpp-llama3-8b-instruct-bartowski-q5km serverside-applied
service/llamacpp serverside-applied
+ kubectl run clichat --image=clichat:latest --rm=true -it --image-pull-policy=IfNotPresent --env=LLM_ENDPOINT=http://llamacpp:80
If you don't see a command prompt, try pressing enter.

> who are you
	I am LLaMA, a helpful AI assistant. I'm here to assist you with any questions or tasks you may have.

Which issue(s) this PR fixes

Fixes #

Special notes for your reviewer

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 9, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 9, 2024
@carlory
Copy link
Member Author

carlory commented Sep 9, 2024

/test pull-lws-test-e2e-main-1-27

@k8s-ci-robot
Copy link
Contributor

@carlory: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-lws-test-e2e-main-1-28
  • /test pull-lws-test-e2e-main-1-29
  • /test pull-lws-test-e2e-main-1-30
  • /test pull-lws-test-e2e-main-1-31
  • /test pull-lws-test-integration-main
  • /test pull-lws-test-unit-main
  • /test pull-lws-verify-main

Use /test all to run the following jobs that were automatically triggered:

  • pull-lws-test-e2e-main-1-28
  • pull-lws-test-e2e-main-1-29
  • pull-lws-test-e2e-main-1-30
  • pull-lws-test-e2e-main-1-31
  • pull-lws-test-integration-main
  • pull-lws-test-unit-main

In response to this:

/test pull-lws-test-e2e-main-1-27

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@liurupeng
Copy link
Collaborator

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 10, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carlory, liurupeng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2024
@k8s-ci-robot k8s-ci-robot merged commit 433d7df into kubernetes-sigs:main Sep 10, 2024
8 checks passed
@carlory carlory deleted the macos branch September 10, 2024 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants