Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some nits in conformance package #124

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Fix some nits in conformance package #124

merged 1 commit into from
Jul 18, 2023

Conversation

Dyanngg
Copy link
Contributor

@Dyanngg Dyanngg commented Jul 17, 2023

Namely:

  • Renaming variables so that it fits their purposes
  • Fixing some comments in admin-network-policy-core-integration.go
  • Making comments more verbose in general

@Dyanngg
Fix some nits in conformance package
9ad14c2 
Namely:
- Renaming variables so that it fits their purposes
- Fixing some comments  and making them more verbose

Signed-off-by: Dyanngg <dingyang@vmware.com>
@Dyanngg Dyanngg added the area/conformance Issues or PRs related to conformance testing label Jul 17, 2023
@Dyanngg Dyanngg requested a review from tssurya July 17, 2023 21:07
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 17, 2023
@netlify
Copy link

netlify bot commented Jul 17, 2023 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-network-policy-api ready!

Name Link
🔨 Latest commit 9ad14c2
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-network-policy-api/deploys/64b5ada675fa2500082238bd
😎 Deploy Preview https://deploy-preview-124--kubernetes-sigs-network-policy-api.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 17, 2023
@tssurya
Copy link
Contributor

tssurya commented Jul 18, 2023

/assign @tssurya

tssurya
tssurya approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@tssurya tssurya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
thanks @Dyanngg
I guess I started the wrong server/client naming in one file and then rest were copy-paste snafu lol
also the extra comments you added make sense to me.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 18, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Dyanngg, tssurya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit fed6822 into kubernetes-sigs:master Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tssurya tssurya tssurya approved these changes

@astoycos astoycos Awaiting requested review from astoycos

@danwinship danwinship Awaiting requested review from danwinship

Assignees

@tssurya tssurya

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance Issues or PRs related to conformance testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dyanngg @tssurya @k8s-ci-robot