Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more detailed instructions about user stories and new Objects #14

Merged
merged 3 commits into from
Jun 11, 2021

Conversation

astoycos
Copy link
Member

@astoycos astoycos commented Jun 8, 2021

Add some more notes on how to form and organize new userstories, following the existing k8's readme formatting rules

Create two empty directories for v1 and v2 apis

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 8, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astoycos

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from abhiraut and rikatz June 8, 2021 20:16
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 8, 2021
astoycos added 2 commits June 8, 2021 16:19
Add more information reguarding the user story structure

Signed-off-by: Andrew Stoycos <astoycos@redhat.com>
To align with instructions in main `userstories`
README

Signed-off-by: Andrew Stoycos <astoycos@redhat.com>
@astoycos astoycos force-pushed the add-formatting-details branch from 06b7412 to 2a5a849 Compare June 8, 2021 20:20

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Contributor

@abhiraut abhiraut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 11, 2021
@k8s-ci-robot k8s-ci-robot merged commit 379c3f3 into kubernetes-sigs:master Jun 11, 2021
astoycos pushed a commit to astoycos/network-policy-api that referenced this pull request Feb 8, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
treat netpol with missing namespace as in 'default' namespace
tssurya pushed a commit to tssurya/network-policy-api that referenced this pull request Sep 12, 2022

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
treat netpol with missing namespace as in 'default' namespace
tssurya pushed a commit to tssurya/network-policy-api that referenced this pull request Sep 30, 2022

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
treat netpol with missing namespace as in 'default' namespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants