Add validation for ANP/BANP Enum actions #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
✅ Deploy Preview for kubernetes-sigs-network-policy-api ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
PTAL @astoycos and/or @danwinship |
astoycos
reviewed
Mar 26, 2024
Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
tssurya
force-pushed
the
add-action-validation
branch
from
740ee74 to
8454955
Compare
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: astoycos, tssurya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
tssurya
added a commit
to tssurya/ovn-kubernetes
that referenced
this pull request
Mar 28, 2024
Brings in: 1) kubernetes-sigs/network-policy-api#209 2) kubernetes-sigs/network-policy-api#196 3) kubernetes-sigs/network-policy-api#213 Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
tssurya
added a commit
to tssurya/ovn-kubernetes
that referenced
this pull request
Apr 3, 2024
Brings in: 1) kubernetes-sigs/network-policy-api#209 2) kubernetes-sigs/network-policy-api#196 3) kubernetes-sigs/network-policy-api#213 Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
tssurya
added a commit
to tssurya/ovn-kubernetes
that referenced
this pull request
Apr 4, 2024
Brings in: 1) kubernetes-sigs/network-policy-api#209 2) kubernetes-sigs/network-policy-api#196 3) kubernetes-sigs/network-policy-api#213 Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
tssurya
added a commit
to tssurya/ovn-kubernetes
that referenced
this pull request
Apr 5, 2024
Brings in: 1) kubernetes-sigs/network-policy-api#209 2) kubernetes-sigs/network-policy-api#196 3) kubernetes-sigs/network-policy-api#213 Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
tssurya
added a commit
to tssurya/ovn-kubernetes
that referenced
this pull request
Apr 8, 2024
Brings in: 1) kubernetes-sigs/network-policy-api#209 2) kubernetes-sigs/network-policy-api#196 3) kubernetes-sigs/network-policy-api#213 Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
tssurya
added a commit
to tssurya/ovn-kubernetes-1
that referenced
this pull request
Apr 9, 2024
Brings in: 1) kubernetes-sigs/network-policy-api#209 2) kubernetes-sigs/network-policy-api#196 3) kubernetes-sigs/network-policy-api#213 Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com> (cherry picked from commit 57bca707c5f866a24c79767b4af1244ec2463570)
tssurya
added a commit
to tssurya/ovn-kubernetes
that referenced
this pull request
Apr 10, 2024
Brings in: 1) kubernetes-sigs/network-policy-api#209 2) kubernetes-sigs/network-policy-api#196 3) kubernetes-sigs/network-policy-api#213 Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
tssurya
added a commit
to tssurya/ovn-kubernetes
that referenced
this pull request
Apr 11, 2024
Brings in: 1) kubernetes-sigs/network-policy-api#209 2) kubernetes-sigs/network-policy-api#196 3) kubernetes-sigs/network-policy-api#213 Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
tssurya
added a commit
to tssurya/ovn-kubernetes
that referenced
this pull request
Apr 15, 2024
Brings in: 1) kubernetes-sigs/network-policy-api#209 2) kubernetes-sigs/network-policy-api#196 3) kubernetes-sigs/network-policy-api#213 Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
tssurya
added a commit
to tssurya/ovn-kubernetes
that referenced
this pull request
Apr 15, 2024
Brings in: 1) kubernetes-sigs/network-policy-api#209 2) kubernetes-sigs/network-policy-api#196 3) kubernetes-sigs/network-policy-api#213 Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
tssurya
added a commit
to tssurya/ovn-kubernetes-1
that referenced
this pull request
Apr 16, 2024
Brings in: 1) kubernetes-sigs/network-policy-api#209 2) kubernetes-sigs/network-policy-api#196 3) kubernetes-sigs/network-policy-api#213 Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
tssurya
added a commit
to tssurya/ovn-kubernetes
that referenced
this pull request
Apr 17, 2024
Brings in: 1) kubernetes-sigs/network-policy-api#209 2) kubernetes-sigs/network-policy-api#196 3) kubernetes-sigs/network-policy-api#213 Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Credit to @asood-rh who put
passandallowinstead ofPassandAllowwhich causes panic (I admit panic was too much over-reaction on the implementation side, but really this needs to be fixed in the API because we clearly state what our enum allowed values are and we don't want to have confusion onpass,Pass,PASSetc).Tested output with this fix:
The AdminNetworkPolicy "node-as-egress-peers" is invalid: spec.egress[0].action: Unsupported value: "allow": supported values: "Allow", "Deny", "Pass"