Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Links to Contributing and Developer Guides in README #53

Conversation

cailyn-codes
Copy link

solves: #49

I've added a very small sentence to link to the contributing guidelines and developer guide - is this what you were thinking or would you like additional detail on how to contribute?

Note that the contributing guidelines are also linked when someone (like me!) opens their first PR on the repo. Should we avoid the duplication, or is the link useful before someone gets to the point of creating a PR?

Screenshot 2022-11-02 at 3 50 52 PM

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 2, 2022
@netlify
Copy link

netlify bot commented Nov 2, 2022

Deploy Preview for kubernetes-sigs-network-policy-api ready!

Name Link
🔨 Latest commit 0b4d44e
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-network-policy-api/deploys/6362cabfff631f000a50e41f
😎 Deploy Preview https://deploy-preview-53--kubernetes-sigs-network-policy-api.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 2, 2022
@rikatz
Copy link

rikatz commented Nov 2, 2022

I think adding the contrib guideline is fine as sometimes people look for that before really opening the PR

/lgtm
/approve
Thanks

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 2, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cailynse, rikatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2022
@k8s-ci-robot k8s-ci-robot merged commit 7182a2c into kubernetes-sigs:master Nov 2, 2022
@astoycos
Copy link
Member

astoycos commented Nov 2, 2022

No this is perfect, thanks @cailynse!!!

Also our README generally isn't that nice at the moment if you have time/ want to tackle something definitely feel free to!

At the very least we should be pointing folks to our website -> https://network-policy-api.sigs.k8s.io/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants