Update github links referencing master to reference HEAD #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
consideRatio
force-pushed
the
pr/transition-master-links-to-HEAD-links
branch
from
3dad235 to
1a224a6
Compare
k8s-ci-robot
added
size/S
Closed
|
/lgtm |
k8s-ci-robot
added
the
lgtm
As expected that didn't work. /assign @wongma7 |
|
/assign @kmova @ashishranjan738 @kvaps |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: consideRatio, kmova The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Needed for kubernetes/k8s.io#1597
Which issue(s) this PR fixes (optional, using fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Needed for kubernetes/k8s.io#1597
As described in #55:
Due to this, I've excluded those files from being modified in this PR but instead created kubernetes-csi/csi-release-tools#165 for that.
And, files in
vendoredshould not be updated either I assume. So, this PR updates all github links pointing to a hardcoded default branchmasterto the dynamic default branch referenceHEADthat will reference either master or main depending on the actual default branch in the github repo.