Fixing liveness and readiness probes for master deployment

kubernetes-sigs · May 7, 2024 · 407957d · 407957d
1 parent f4a8788
commit 407957d
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 18 deletions.
diff --git a/internal/deployment/deployment.go b/internal/deployment/deployment.go
@@ -262,11 +262,8 @@ func getLivenessProbe() *corev1.Probe {
 	return &corev1.Probe{
 		InitialDelaySeconds: 10,
 		ProbeHandler: corev1.ProbeHandler{
-			Exec: &corev1.ExecAction{
-				Command: []string{
-					"/usr/bin/grpc_health_probe",
-					"-addr=:12000",
-				},
+			GRPC: &corev1.GRPCAction{
+				Port: 8082,
 			},
 		},
 	}
@@ -277,11 +274,8 @@ func getReadinessProbe() *corev1.Probe {
 		InitialDelaySeconds: 5,
 		FailureThreshold:    10,
 		ProbeHandler: corev1.ProbeHandler{
-			Exec: &corev1.ExecAction{
-				Command: []string{
-					"/usr/bin/grpc_health_probe",
-					"-addr=:12000",
-				},
+			GRPC: &corev1.GRPCAction{
+				Port: 8082,
 			},
 		},
 	}

diff --git a/internal/deployment/testdata/test_master_deployment.yaml b/internal/deployment/testdata/test_master_deployment.yaml
@@ -70,15 +70,11 @@ spec:
               - ALL
             readOnlyRootFilesystem: true
           livenessProbe:
-            exec:
-              command:
-              - /usr/bin/grpc_health_probe
-              - -addr=:12000
+            grpc:
+              port: 8082
             initialDelaySeconds: 10
           readinessProbe:
-            exec:
-              command:
-              - /usr/bin/grpc_health_probe
-              - -addr=:12000
+            grpc:
+              port: 8082
             failureThreshold: 10
             initialDelaySeconds: 5