Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align with k8s-sigs nomenclature #132

Merged
merged 1 commit into from
Feb 18, 2022
Merged

Align with k8s-sigs nomenclature #132

merged 1 commit into from
Feb 18, 2022

Conversation

ArangoGutierrez
Copy link
Contributor

Basically -> s/github.com\/kubernetes-sigs/sigs.k8s.io/g
Signed-off-by: Carlos Eduardo Arango Gutierrez carangog@redhat.com

@ArangoGutierrez ArangoGutierrez added this to the v0.5.0 milestone Feb 17, 2022
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 17, 2022
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 17, 2022
@ArangoGutierrez ArangoGutierrez mentioned this pull request Feb 17, 2022
Merged
@ArangoGutierrez
Copy link
Contributor Author

/assign @marquiz

marquiz
marquiz reviewed Feb 17, 2022
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For go packages 👍 For other URLs 👎

.github/ISSUE_TEMPLATE/release.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/release.md Outdated Show resolved Hide resolved
PROJECT Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
RELEASE.md Outdated Show resolved Hide resolved
RELEASE.md Outdated Show resolved Hide resolved
@ArangoGutierrez ArangoGutierrez force-pushed the devel/k8s-sigs_nomenclature branch from d4ca588 to 3558bb3 Compare February 17, 2022 21:08
@ArangoGutierrez
Copy link
Contributor Author

@marquiz ready for a next round

marquiz
marquiz requested changes Feb 17, 2022
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave the documentation unchanged

docs/advanced/developer-guide.md Outdated Show resolved Hide resolved
@ArangoGutierrez ArangoGutierrez force-pushed the devel/k8s-sigs_nomenclature branch from 3558bb3 to 499b83d Compare February 17, 2022 21:27
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 17, 2022
marquiz
marquiz requested changes Feb 18, 2022
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert all changes to docs/

@ArangoGutierrez ArangoGutierrez force-pushed the devel/k8s-sigs_nomenclature branch from 499b83d to 4ca9682 Compare February 18, 2022 12:19
@ArangoGutierrez
Copy link
Contributor Author

Please revert all changes to docs/

Done, ready for review

@ArangoGutierrez
Align with k8s-sigs nomenclature
e506b76 
Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>
@ArangoGutierrez ArangoGutierrez force-pushed the devel/k8s-sigs_nomenclature branch from 4ca9682 to e506b76 Compare February 18, 2022 12:25
@ArangoGutierrez
Copy link
Contributor Author

Everything un /doc restored

marquiz
marquiz approved these changes Feb 18, 2022
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ArangoGutierrez
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 18, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ArangoGutierrez,marquiz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 7d50803 into kubernetes-sigs:master Feb 18, 2022
@ArangoGutierrez ArangoGutierrez mentioned this pull request May 17, 2022
Closed
31 tasks
@ArangoGutierrez ArangoGutierrez deleted the devel/k8s-sigs_nomenclature branch March 13, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marquiz marquiz marquiz approved these changes

@zvonkok zvonkok Awaiting requested review from zvonkok

Assignees

@marquiz marquiz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ArangoGutierrez @k8s-ci-robot @marquiz