Run nfd-master as Deployment

[ArangoGutierrez]

Fixes #4

Also harden RBAC requested by the controller

[ArangoGutierrez]

/cherry-pick release-0.4

[k8s-infra-cherrypick-robot]

@ArangoGutierrez: once the present PR merges, I will cherry-pick it on top of release-0.4 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[marquiz]

@ArangoGutierrez could the RBAC rule changes be split out into a separate PR? At least those that are not required by the Deployment change.

[marquiz]

Thanks @ArangoGutierrez. Some quick nits about the deployment files 😄

[marquiz]

I don't think you should change config/rbac/role.yaml

[marquiz]

Thanks @ArangoGutierrez! Looks good, now
/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ArangoGutierrez,marquiz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-infra-cherrypick-robot]

@ArangoGutierrez: #141 failed to apply on top of branch "release-0.4":

Applying: Run nfd-master as Deployment
.git/rebase-apply/patch:110: trailing whitespace.
            weight: 1  
.git/rebase-apply/patch:118: trailing whitespace.
                fieldPath: spec.nodeName      
.git/rebase-apply/patch:130: trailing whitespace.
            runAsNonRoot: true  
warning: 3 lines add whitespace errors.
Using index info to reconstruct a base tree...
M	config/manager/kustomization.yaml
A	config/manifests/bases/nfd-operator.clusterserviceversion.yaml
A	config/manifests/kustomization.yaml
M	config/rbac/role.yaml
M	controllers/nodefeaturediscovery_controller.go
M	controllers/nodefeaturediscovery_controls.go
M	controllers/nodefeaturediscovery_finalizers.go
M	controllers/nodefeaturediscovery_status.go
Falling back to patching base and 3-way merge...
Auto-merging controllers/nodefeaturediscovery_status.go
Auto-merging controllers/nodefeaturediscovery_finalizers.go
Auto-merging controllers/nodefeaturediscovery_controls.go
Auto-merging controllers/nodefeaturediscovery_controller.go
Auto-merging config/rbac/role.yaml
CONFLICT (modify/delete): config/manifests/kustomization.yaml deleted in HEAD and modified in Run nfd-master as Deployment. Version Run nfd-master as Deployment of config/manifests/kustomization.yaml left in tree.
CONFLICT (modify/delete): config/manifests/bases/nfd-operator.clusterserviceversion.yaml deleted in HEAD and modified in Run nfd-master as Deployment. Version Run nfd-master as Deployment of config/manifests/bases/nfd-operator.clusterserviceversion.yaml left in tree.
Auto-merging config/manager/kustomization.yaml
CONFLICT (content): Merge conflict in config/manager/kustomization.yaml
Removing build/assets/master/0400_master_daemonset.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Run nfd-master as Deployment
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-0.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.