Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable automated Prune via CRD NodeFeatureDiscoveries #188

Merged
merged 1 commit into from
Mar 15, 2023
Merged

Enable automated Prune via CRD NodeFeatureDiscoveries #188

merged 1 commit into from
Mar 15, 2023

Conversation

ArangoGutierrez
Copy link
Contributor

Fixes: #187

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 14, 2023
@k8s-ci-robot k8s-ci-robot requested review from marquiz and zvonkok March 14, 2023 17:48
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 14, 2023
@ArangoGutierrez ArangoGutierrez changed the title Prune Enable automated Prune via CRD NodeFeatureDiscoveries Mar 14, 2023
marquiz
marquiz reviewed Mar 14, 2023
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ArangoGutierrez. I'll take a closer look in the coming days

api/v1/nodefeaturediscovery_types.go Outdated Show resolved Hide resolved
@ArangoGutierrez ArangoGutierrez added this to the v0.6.0 milestone Mar 14, 2023
@ArangoGutierrez ArangoGutierrez force-pushed the prune branch 3 times, most recently from 11bf82d to 3c7c878 Compare March 14, 2023 19:35
marquiz
marquiz reviewed Mar 15, 2023
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ArangoGutierrez for this enhancement. From what I can tell, looks pretty legit to me (if it works, haven't tested 😅). Just a few comments but nothing big

build/assets/prune/0200_clusterrole.yaml Outdated Show resolved Hide resolved
build/assets/prune/0200_clusterrole.yaml Outdated Show resolved Hide resolved
build/assets/prune/0300_clusterole_binding.yaml Outdated Show resolved Hide resolved
controllers/nodefeaturediscovery_controls.go Outdated Show resolved Hide resolved
controllers/nodefeaturediscovery_controls.go Outdated
return NotReady, err
}

// If we found the Job, let's attempt to update it
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, is it generally useful to update the job if it happens to exist? It doesn't retrigger it, if I'm not mistaken. Should we just delete or re-create or what would be the right thing to do?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch.
first check if successful and if not do something else

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about now?

controllers/nodefeaturediscovery_finalizers.go Outdated Show resolved Hide resolved
@ArangoGutierrez
Enable automated Prune via CRD NodeFeatureDiscoveries
8bea7b8 
Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
@ArangoGutierrez ArangoGutierrez requested a review from marquiz March 15, 2023 16:00
marquiz
marquiz approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ArangoGutierrez. Looks like we're done here
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 15, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ArangoGutierrez,marquiz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 44a0934 into kubernetes-sigs:master Mar 15, 2023
@ArangoGutierrez ArangoGutierrez deleted the prune branch March 15, 2023 18:07
@ArangoGutierrez ArangoGutierrez mentioned this pull request Mar 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marquiz marquiz marquiz approved these changes

@zvonkok zvonkok Awaiting requested review from zvonkok

Assignees

@marquiz marquiz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging this pull request may close these issues.

Enable automated Prune via CRD NodeFeatureDiscoveries
3 participants
@ArangoGutierrez @k8s-ci-robot @marquiz