add support for config IMAGE_TAG and rbac proxy image

[zwpaper]

According to

node-feature-discovery-operator/docs/get-started/quick-start.md

Line 18 in b5efc6f

IMAGE_TAG={{ site.container_image }}

IMAGE_TAG could be configured for changing deploy image and tag, but not in the makefile, so I updated it.

Also, I add an extra variable IMAGE_TAG_RBAC_PROXY, gcr.io/kubebuilder/kube-rbac-proxy:v0.5.0 by default, for the rbac proxy image and tag, so that we could change it when deploying.

I noticed there is both $(shell pwd) and $(PROJECT_DIR) in the Makefile, it may cause confusion, so that I changed them to a uniq $(PROJECT_DIR)

[k8s-ci-robot]

Welcome @zwpaper!

It looks like this is your first PR to kubernetes-sigs/node-feature-discovery-operator 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/node-feature-discovery-operator has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @zwpaper. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ArangoGutierrez]

Thanks for this PR @zwpaper
just a comment before moving forward

[ArangoGutierrez]

Let's keep this one as v0.5.0 avoid using latest tag at all cost

[zwpaper]

updated to v0.5.0, although we will not use this image and tag here, it should always be updated to the one in Makefile by kustomization.

I noticed one of my mistakes, kustomization should change the RBAC image in config/default instead of config/manager, it is now tested and works as expected.

btw, I also noticed there is both $(shell pwd) and $(PROJECT_DIR) in the Makefile, it may cause confusion so that I changed them to a unique $(PROJECT_DIR)

thanks for the review!

[ArangoGutierrez]

/ok-to-test

[ArangoGutierrez]

Thanks for the patch!
/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, zwpaper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ArangoGutierrez]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment