Skip to content

Commit

Permalink
Add revision history limit for master replica and for garbage collector
Browse files Browse the repository at this point in the history
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
  • Loading branch information
omerap12 committed Jul 11, 2024
1 parent 393af96 commit 2fe8188
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ metadata:
{{- end }}
spec:
replicas: {{ .Values.master.replicaCount }}
revisionHistoryLimit: {{ .Values.master.revisionHistoryLimit }}
selector:
matchLabels:
{{- include "node-feature-discovery.selectorLabels" . | nindent 6 }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ metadata:
{{- end }}
spec:
replicas: {{ .Values.gc.replicaCount | default 1 }}
revisionHistoryLimit: {{ .Values.gc.revisionHistoryLimit }}
selector:
matchLabels:
{{- include "node-feature-discovery.selectorLabels" . | nindent 6 }}
Expand Down
4 changes: 4 additions & 0 deletions deployment/helm/node-feature-discovery/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,8 @@ master:
# The name of the service account to use.
# If not set and create is true, a name is generated using the fullname template
name:

revisionHistoryLimit: 3

rbac:
create: true
Expand Down Expand Up @@ -544,6 +546,8 @@ gc:
deploymentAnnotations: {}
affinity: {}

revisionHistoryLimit: 3

# Optionally use encryption for worker <--> master comms
# TODO: verify hostname is not yet supported
#
Expand Down

0 comments on commit 2fe8188

Please sign in to comment.