Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a humen readable cpu model name. #1220

Closed
cnfatal opened this issue May 8, 2023 · 4 comments
Closed

Add a humen readable cpu model name. #1220

cnfatal opened this issue May 8, 2023 · 4 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@cnfatal
Copy link

cnfatal commented May 8, 2023

What would you like to be added:

Add a human readable model_name in cpu-model. like:

    feature.node.kubernetes.io/cpu-model.model_name: "Intel(R) Xeon(R) Gold XXXX CPU @ 2.00GHz"

or

    feature.node.kubernetes.io/cpu-model.name: "Intel(R) Xeon(R) Gold XXXX CPU @ 2.00GHz"

Why is this needed:

If this is accepted, I'd be happy to open a PR. 😀

@cnfatal cnfatal added the kind/feature Categorizes issue or PR as related to a new feature. label May 8, 2023
@cnfatal
Copy link
Author

cnfatal commented May 8, 2023

Intel(R) Xeon(R) Gold XXXX CPU @ 2.00GHz is not a valid kubernetes label value. may close this issue

a valid label must be an empty string or consist of alphanumeric characters, '-', '_' or '.', 
and must start and end with an alphanumeric character (e.g. 'MyValue',  or 'my_value',  or '12345', 
regex used for validation is '(([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9])?')

@marquiz
Copy link
Contributor

marquiz commented May 8, 2023

/close

@k8s-ci-robot
Copy link
Contributor

@marquiz: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants