Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

worker: move code #1020

Merged
merged 1 commit into from
Dec 27, 2022
Merged

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Dec 23, 2022

Simplify code bu dropping the unnecessary base client package.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 23, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 23, 2022
@netlify
Copy link

netlify bot commented Dec 23, 2022

Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit 1026d91
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/63a5771c99564800092e7cb3
😎 Deploy Preview https://deploy-preview-1020--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@marquiz
Copy link
Contributor Author

marquiz commented Dec 23, 2022

Depends on #1018
/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 23, 2022
@marquiz
Copy link
Contributor Author

marquiz commented Dec 23, 2022

/assign @ArangoGutierrez @fmuyassarov

Simplify code bu dropping the unnecessary base client package.
@marquiz marquiz force-pushed the devel/worker-refactor branch from 85464da to 1026d91 Compare December 23, 2022 09:38
@marquiz
Copy link
Contributor Author

marquiz commented Dec 23, 2022

Rebased, #1018 merged
/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 23, 2022
Copy link
Member

@fmuyassarov fmuyassarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 27, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5e9be0a67551c82c8242cc98038ab446f5c6d434

@k8s-ci-robot k8s-ci-robot merged commit 8eb6640 into kubernetes-sigs:master Dec 27, 2022
@marquiz marquiz deleted the devel/worker-refactor branch January 2, 2023 10:22
@marquiz marquiz mentioned this pull request Apr 12, 2023
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants