Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OWNERS: Update Ethyling username to jjacobelli #1056

Merged
merged 1 commit into from
Feb 14, 2023
Merged

OWNERS: Update Ethyling username to jjacobelli #1056

merged 1 commit into from
Feb 14, 2023

Conversation

jjacobelli
Copy link
Contributor

I recently changed my username from Ethyling to jjacobelli so I'm updating the OWNERS file to reflect this change

@netlify
Copy link

netlify bot commented Feb 12, 2023 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit bf43f5b
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/63e9f85c79ff930008fc81b4
😎 Deploy Preview https://deploy-preview-1056--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 12, 2023
marquiz
marquiz reviewed Feb 13, 2023
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, But let's change the username in .github/ISSUE_TEMPLATE/new-release.md, too

@jjacobelli
OWNERS: Update Ethyling username to jjacobelli
bf43f5b 
Signed-off-by: Jordan Jacobelli <jjacobelli@nvidia.com>
@jjacobelli
Copy link
Contributor Author

Ack, But let's change the username in .github/ISSUE_TEMPLATE/new-release.md, too

Oh, good catch, PR updated

marquiz
marquiz approved these changes Feb 13, 2023
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2023
@marquiz
Copy link
Contributor

marquiz commented Feb 14, 2023

/assign @ArangoGutierrez @fmuyassarov

ArangoGutierrez
ArangoGutierrez approved these changes Feb 14, 2023
View reviewed changes
Copy link
Contributor

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also have a user name with Upper case, but I am too lazy to go through all the needed changes
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 14, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c7de8daf91fd16935b62a2076d48037f16f0d839

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, jjacobelli, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 22b1bb7 into kubernetes-sigs:master Feb 14, 2023
@marquiz marquiz mentioned this pull request Apr 12, 2023
Closed
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArangoGutierrez ArangoGutierrez ArangoGutierrez approved these changes

@marquiz marquiz marquiz approved these changes

@fmuyassarov fmuyassarov Awaiting requested review from fmuyassarov

@kad kad Awaiting requested review from kad

Assignees

@ArangoGutierrez ArangoGutierrez

@fmuyassarov fmuyassarov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jjacobelli @marquiz @k8s-ci-robot @ArangoGutierrez @fmuyassarov