-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement kernel version detection #157
Implement kernel version detection #157
Conversation
26cae36
to
715fec8
Compare
Verified #149 and #157 on generic CentOS:
and custom ubuntu kernel:
|
715fec8
to
26b3555
Compare
Based on discussion in #140, I changed the label names so that there now is a dot (instead of dash) between
|
b4b47cb
to
ada254f
Compare
Again LGTM with new naming convention! |
Make it possible to advertise also other than simple 'true' values for feature labels.
Add a new 'kernel' feature source, detecting the kernel version. The kernel version is split into multiple labels in order to make this more usable in label selectors. Kernel version in the format X.Y.Z-patch will be presented as node.alpha.kubernetes-incubator.io/nfd-kernel-version.full=X.Y.Z-patch node.alpha.kubernetes-incubator.io/nfd-kernel-version.major=X node.alpha.kubernetes-incubator.io/nfd-kernel-version.minor=Y node.alpha.kubernetes-incubator.io/nfd-kernel-version.revision=Z The '.full' label will always be avaiable. The other labels if these components can be parsed from the kernel version number.
ada254f
to
3509a0c
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Version 0.4.0 Node-feature-discovery was migrated into a new repository under the kubernetes-sigs organization in Github (kubernetes-sigs#175). Related to the migration, the final container image registry/repo hasn't been dediced yet (kubernetes-sigs#177) – for this release we still use the old repo. Major changes - Split NFD into client and server (kubernetes-sigs#209) - Changes in labels: - NFD label namespace was changed to 'feature.node.kubernetes.io/' (kubernetes-sigs#176) - 'nfd-' prefix was dropped from all feature labels - NFD version label (feature.node.kubernetes.io/node-feature-discovery.version) was replaced by an annotation (nfd.node.kubernetes.io/version) - network SRIOV labels were changed (kubernetes-sigs#173): - 'network-sriov' -> 'network-sriov.capable' - 'network-sriov-configured' -> 'network-sriov.configured' - selinux detection was moved to kernel feature source - 'selinux' -> 'kernel-selinux.enabled' - cpuid, pstate and RDT labels moved under cpu feature source (kubernetes-sigs#217) - 'cpuid-<cpuid flag>' -> 'cpu-cpuid.<cpuid flag>' - 'pstate-turbo' -> 'cpu-pstate.turbo' - 'rdt-<rdt feature>' -> 'cpu-rdt.<rdt feature>' - Support for config file (kubernetes-sigs#169). Currently with three configurable feature sources i.e. cpu (kubernetes-sigs#224), kernel (kubernetes-sigs#157) and pci (kubernetes-sigs#168) - Support for non-binary labels, with arbitrary values other than plain 'true' - PCI device detection (kubernetes-sigs#168) - Kernel version detection (kubernetes-sigs#157) - Kernel config option detection (kubernetes-sigs#146) - Support for custom feature-detector hooks (kubernetes-sigs#144) - Support OS version detection (kubernetes-sigs#149, kubernetes-sigs#211) - Detection of hardware multithreading, such as Intel Hyper-Threading Technology (kubernetes-sigs#147) - Arm64 support for CPUID detection (kubernetes-sigs#194) - Validation of feature label names and values (kubernetes-sigs#199, kubernetes-sigs#219) - Detection of NVDIMM devices (kubernetes-sigs#214) - Get labels by reading from file in 'local' source (kubernetes-sigs#228) - Detection of Intel SST-BF (Speed Select Technology - Base Frequency) (kubernetes-sigs#235) - Make it possible to create feature labels in non-default namespace (kubernetes-sigs#231). Currently possible for using the local source (hooks and files). Miscellaneous - Template specs converted from json to yaml - Documentation updates and fixes
Make it possible to advertise also other than simple 'true' values for
feature labels.
Add a new 'kernel' feature source, detecting the kernel version. The
kernel version is split into multiple labels in order to make this more
usable in label selectors. Kernel version in the format X.Y.Z-patch will
be presented as
node.alpha.kubernetes-incubator.io/nfd-kernel-version-full=X.Y.Z-patch
node.alpha.kubernetes-incubator.io/nfd-kernel-version-major=X
node.alpha.kubernetes-incubator.io/nfd-kernel-version-minor=Y
node.alpha.kubernetes-incubator.io/nfd-kernel-version-revision=Z
The '-full' label will always be avaiable. The other labels if these
components can be parsed from the kernel version number.