Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure post-delete-job's service account matches ref in job spec #1746

Merged

Conversation

tariq1890
Copy link
Contributor

@tariq1890 tariq1890 commented Jun 17, 2024

The Service account name must match the referenced service account in the job spec

With helm chart as-is, the gpu-operator e2e tests fail as the helm uninstall operation fails and times out. On further analysis, we found that the delete hook job can't find the service account it looks for, so the job remains unprovisioned until the helm uninstall times out

This change fixes the above issue. I've tested this locally and our gpu-operator e2e tests now pass

Signed-off-by: Tariq Ibrahim <tibrahim@nvidia.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 17, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 17, 2024
Copy link

netlify bot commented Jun 17, 2024

Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit 8e1907f
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/6670a8f7e4951100087114db
😎 Deploy Preview https://deploy-preview-1746--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tariq1890
Copy link
Contributor Author

/assign @ArangoGutierrez

@ArangoGutierrez
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jun 17, 2024
Copy link
Contributor

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
@marquiz ?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 18, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 304632045979d36db27530bb74654c875c96f177

@ArangoGutierrez
Copy link
Contributor

/cc TessaIO kad

@k8s-ci-robot k8s-ci-robot requested review from kad and TessaIO June 26, 2024 15:36
@TessaIO
Copy link
Member

TessaIO commented Jun 26, 2024

/lgtm

@TessaIO
Copy link
Member

TessaIO commented Jun 27, 2024

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, tariq1890

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2024
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.50%. Comparing base (b384c2e) to head (8e1907f).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1746   +/-   ##
=======================================
  Coverage   39.50%   39.50%           
=======================================
  Files          80       80           
  Lines        7161     7161           
=======================================
  Hits         2829     2829           
  Misses       4072     4072           
  Partials      260      260           

@k8s-ci-robot k8s-ci-robot merged commit 0418e7d into kubernetes-sigs:master Jun 27, 2024
9 checks passed
@marquiz
Copy link
Contributor

marquiz commented Jun 27, 2024

/cherry-pick release-0.16

@k8s-infra-cherrypick-robot

@marquiz: new pull request created: #1750

In response to this:

/cherry-pick release-0.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tariq1890 tariq1890 deleted the prune-svc-account-name branch June 28, 2024 18:46
@marquiz marquiz mentioned this pull request Dec 12, 2024
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants