-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ensure post-delete-job's service account matches ref in job spec #1746
ensure post-delete-job's service account matches ref in job spec #1746
Conversation
Signed-off-by: Tariq Ibrahim <tibrahim@nvidia.com>
✅ Deploy Preview for kubernetes-sigs-nfd ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/assign @ArangoGutierrez |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@marquiz ?
LGTM label has been added. Git tree hash: 304632045979d36db27530bb74654c875c96f177
|
/cc TessaIO kad |
/lgtm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ArangoGutierrez, tariq1890 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1746 +/- ##
=======================================
Coverage 39.50% 39.50%
=======================================
Files 80 80
Lines 7161 7161
=======================================
Hits 2829 2829
Misses 4072 4072
Partials 260 260 |
/cherry-pick release-0.16 |
@marquiz: new pull request created: #1750 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
The Service account name must match the referenced service account in the job spec
With helm chart as-is, the gpu-operator e2e tests fail as the
helm uninstall
operation fails and times out. On further analysis, we found that the delete hook job can't find the service account it looks for, so the job remains unprovisioned until the helm uninstall times outThis change fixes the above issue. I've tested this locally and our gpu-operator e2e tests now pass