Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nfd-gc: check that node informer cache sync succeeded #1812

Merged
merged 1 commit into from
Jul 26, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion pkg/nfd-gc/nfd-gc.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ package nfdgarbagecollector

import (
"context"
"fmt"
"time"

topologyclientset "github.com/k8stopologyawareschedwg/noderesourcetopology-api/pkg/generated/clientset/versioned"
Expand Down Expand Up @@ -208,7 +209,15 @@ func (n *nfdGarbageCollector) startNodeInformer() error {

// start informers
n.factory.Start(n.stopChan)
n.factory.WaitForCacheSync(n.stopChan)

start := time.Now()
ret := n.factory.WaitForCacheSync(n.stopChan)
for res, ok := range ret {
if !ok {
return fmt.Errorf("node informer cache failed to sync (%s)", res)
}
}
klog.InfoS("node informer cache synced", "duration", time.Since(start))

return nil
}
Expand Down