Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tilt: sync up builder go version with project go.mod #1827

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

fmuyassarov
Copy link
Member

@fmuyassarov fmuyassarov commented Aug 7, 2024

Sync up builder go version with project go.mod otherwise build will fail.
Also, add allow_k8s_contexts('kubernetes-admin@kubernetes') to allow tilt to run on production like clusters.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 7, 2024
@k8s-ci-robot k8s-ci-robot requested review from kad and PiotrProkop August 7, 2024 12:43
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 7, 2024
Copy link

netlify bot commented Aug 7, 2024

Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit a7d8448
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/66b5320bb01067000828eb0e
😎 Deploy Preview https://deploy-preview-1827--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@fmuyassarov
Copy link
Member Author

cc @marquiz

Tiltfile Outdated Show resolved Hide resolved
@marquiz
Copy link
Contributor

marquiz commented Aug 8, 2024

/retest

@marquiz
Copy link
Contributor

marquiz commented Aug 8, 2024

@fmuyassarov easiest way to re-test the netlify is to rebase

Signed-off-by: Feruzjon Muyassarov <feruzjon.muyassarov@intel.com>
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 8, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 52aa43395304fb1948cc251040f6c966c03ae031

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fmuyassarov, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 8, 2024
@k8s-ci-robot k8s-ci-robot merged commit c1db298 into kubernetes-sigs:master Aug 8, 2024
10 checks passed
@marquiz marquiz mentioned this pull request Dec 12, 2024
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants