Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go.mod: bump kubernetes to v1.31 #1837

Merged
merged 4 commits into from
Oct 30, 2024
Merged

go.mod: bump kubernetes to v1.31 #1837

merged 4 commits into from
Oct 30, 2024

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Aug 14, 2024

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 14, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 14, 2024
@netlify Netlify
Copy link

netlify bot commented Aug 14, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit 403ad6c
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/6722099a92bf1a0008039b71
😎 Deploy Preview https://deploy-preview-1837--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

fmuyassarov
fmuyassarov reviewed Aug 14, 2024
View reviewed changes
Copy link
Member

@fmuyassarov fmuyassarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we better wait for kubernetes-sigs/controller-runtime#2925 ?

@fmuyassarov
Copy link
Member

Perhaps we better wait for kubernetes-sigs/controller-runtime#2925 ?

related slack chat: https://app.slack.com/client/T09NY5SBT/CHGFYJVAN

@marquiz
Copy link
Contributor Author

marquiz commented Aug 14, 2024

Yeah, maybe I was A BIT hasty with this one ☺️ I think this needs to wait until the gRPC stuff is dropped (to get rid of the linter deprecation warnings)

@marquiz marquiz mentioned this pull request Aug 19, 2024
Closed
@mythi mythi mentioned this pull request Aug 19, 2024
Closed
@marquiz marquiz mentioned this pull request Sep 3, 2024
Closed
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 4, 2024
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 4, 2024
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 16, 2024
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 17, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 19, 2024
ArangoGutierrez
ArangoGutierrez approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 20, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 75ff74b3c52fd4a94c4504f8b59aae3194c2cc15

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 10, 2024
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 30, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 30, 2024
@marquiz
go.mod: bump kubernetes to v1.31
9261c36
@marquiz
nfd-master: use Typed* workqueue types
ca85075 
Drop the usage of deprecated functions and types, makes linters happy.
@marquiz
generate: update packages
4d102c5
@marquiz
Update auto-generated code
403ad6c 
Run make generate after updating generator tools.
@marquiz
Copy link
Contributor Author

marquiz commented Oct 30, 2024

@ArangoGutierrez PTAL

@marquiz
Copy link
Contributor Author

marquiz commented Oct 30, 2024

/retest

ArangoGutierrez
ArangoGutierrez approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 30, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0be4e74da653848ac1caa57742e08ee4b2758fd6

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ArangoGutierrez,marquiz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@marquiz
Copy link
Contributor Author

marquiz commented Oct 30, 2024

/retest

@k8s-ci-robot k8s-ci-robot merged commit d13729b into kubernetes-sigs:master Oct 30, 2024
10 checks passed
@marquiz marquiz deleted the devel/deps branch October 30, 2024 15:03
@marquiz marquiz mentioned this pull request Dec 12, 2024
Closed
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmuyassarov fmuyassarov fmuyassarov left review comments

@ArangoGutierrez ArangoGutierrez ArangoGutierrez approved these changes

@zvonkok zvonkok Awaiting requested review from zvonkok

Assignees

@ArangoGutierrez ArangoGutierrez

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marquiz @fmuyassarov @k8s-ci-robot @ArangoGutierrez