Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nfd-worker: Add an option to disable setting the owner references #1860

Merged
merged 1 commit into from
Dec 13, 2024
Merged

nfd-worker: Add an option to disable setting the owner references #1860

merged 1 commit into from
Dec 13, 2024

Conversation

ozhuraki
Copy link
Contributor

In some cases it's desirable to control automatic garbage collection of NodeFeature object.

Add an option to disable setting the owner references to Pod for NodeFeature object.

Closes: #1817

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 30, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @ozhuraki. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 30, 2024
@netlify Netlify
Copy link

netlify bot commented Aug 30, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit 20ef877
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/674886f291f0e5000850a7cf
😎 Deploy Preview https://deploy-preview-1860--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 30, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 4, 2024
@marquiz
Copy link
Contributor

marquiz commented Sep 18, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 18, 2024
@ozhuraki
Copy link
Contributor Author

@marquiz
Thanks! Updated, please take a look

@ozhuraki
Copy link
Contributor Author

@marquiz
Thanks! Updated, please take a look

marquiz
marquiz approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ozhuraki looks good to me now 👍
/assign @ArangoGutierrez

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 31, 2024
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 31, 2024
@marquiz
Copy link
Contributor

marquiz commented Nov 1, 2024

/retest
ping @ArangoGutierrez

fmuyassarov
fmuyassarov reviewed Nov 11, 2024
View reviewed changes
pkg/nfd-worker/nfd-worker.go Outdated Show resolved Hide resolved
pkg/nfd-worker/nfd-worker.go Outdated Show resolved Hide resolved
@ozhuraki
Copy link
Contributor Author

@fmuyassarov

Apologies for a delay. Thanks, updated, please take a look

@marquiz
Copy link
Contributor

marquiz commented Nov 26, 2024

/remove-approve

@k8s-ci-robot k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 26, 2024
@ozhuraki
Copy link
Contributor Author

@marquiz

Thanks, updated. Please take a look

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 28, 2024
@ozhuraki
Copy link
Contributor Author

@marquiz

Thanks, updated. Please take a look

marquiz
marquiz reviewed Nov 28, 2024
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ach, sorry I'm remembering one thing at a time 😬 Could you also update the example config deployment/components/worker-config/nfd-worker.conf.example, (and run make templates to update the helm chart accordingly, too).

@ozhuraki
nfd-worker: Add an option to disable setting the owner references
20ef877 
In some cases it's desirable to control automatic garbage collection
of NodeFeature object.

Add an option to disable setting the owner references to Pod
for NodeFeature object.

Closes: 1817

Signed-off-by: Oleg Zhurakivskyy <oleg.zhurakivskyy@intel.com>
@ozhuraki
Copy link
Contributor Author

@marquiz

Thanks, done.

marquiz
marquiz approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ozhuraki, looks good to me now +1

ping @ArangoGutierrez

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marquiz, ozhuraki

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2024
@marquiz
Copy link
Contributor

marquiz commented Dec 12, 2024

/milestone v0.17

@k8s-ci-robot k8s-ci-robot added this to the v0.17 milestone Dec 12, 2024
@marquiz
Copy link
Contributor

marquiz commented Dec 12, 2024

ping @ArangoGutierrez

@marquiz
Copy link
Contributor

marquiz commented Dec 13, 2024

/assign @TessaIO

@TessaIO
Copy link
Member

TessaIO commented Dec 13, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 13, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: da04c7d02696d991746b1744f69e72aa95f57940

@k8s-ci-robot k8s-ci-robot merged commit caaac59 into kubernetes-sigs:master Dec 13, 2024
12 checks passed
@marquiz marquiz mentioned this pull request Dec 13, 2024
Closed
@marquiz marquiz mentioned this pull request Dec 20, 2024
Closed
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmuyassarov fmuyassarov fmuyassarov left review comments

@marquiz marquiz marquiz approved these changes

@ArangoGutierrez ArangoGutierrez Awaiting requested review from ArangoGutierrez

Assignees

@ArangoGutierrez ArangoGutierrez

@TessaIO TessaIO

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.17
Development

Successfully merging this pull request may close these issues.

NodeFeature resource should not be owned by Pod
6 participants
@ozhuraki @k8s-ci-robot @marquiz @TessaIO @fmuyassarov @ArangoGutierrez