Add separate helm values for the liveness and readiness probes #1913
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
✅ Deploy Preview for kubernetes-sigs-nfd ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
k8s-ci-robot
added
the
size/L
tobiasgiese
force-pushed
the
helm-probes-fix
branch
2 times, most recently
from
fbb2af5 to
45020bd
Compare
Signed-off-by: Tobias Giese <tgiese@nvidia.com>
Signed-off-by: Tobias Giese <tgiese@nvidia.com>
tobiasgiese
force-pushed
the
helm-probes-fix
branch
from
45020bd to
52c2fc6
Compare
|
/assign @marquiz @ArangoGutierrez |
tobiasgiese
changed the title
| {{- with .Values.worker.readinessProbe.periodSeconds }} | ||
| periodSeconds: {{ . }} | ||
| {{- end }} | ||
| {{- with .Values.worker.readinessProbe.timeoutSeconds }} |
There was a problem hiding this comment.
this works when timeoutSecond is not provided in values? just making sure :)
There was a problem hiding this comment.
it works, yes. Currently there are only comments in the values.yaml :)
There was a problem hiding this comment.
Given the NV-heavy presence on this PR, I'll leave the final decision to @marquiz
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 644d8d4a694dce63783a2204123ce4bbce37cfd3
|
There was a problem hiding this comment.
Thanks @tobiasgiese for the improvement.
/lgtm
I have some changes cooking up on this front, too, so stay tuned
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marquiz, tobiasgiese The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Add separate helm values for the liveness and readiness probes
This PR adds separate helm values for the probes. This is necessary to override the health port in the probes.
Follow-up to #1885
Also the
helm.mdhas been reformatted.The updated helm documentation can be seen here: https://deploy-preview-1913--kubernetes-sigs-nfd.netlify.app/deployment/helm