Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nfd-master: check that namespace informer cache sync succeeded #1965

Merged
merged 1 commit into from
Dec 12, 2024
Merged

nfd-master: check that namespace informer cache sync succeeded #1965

merged 1 commit into from
Dec 12, 2024

Conversation

ozhuraki
Copy link
Contributor

Mitigate the namespace cache sync reported in issue #1936

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 29, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @ozhuraki. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 29, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 29, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 29, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit f13ccb1
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/674d9013c393d2000872144c
😎 Deploy Preview https://deploy-preview-1965--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ozhuraki
nfd-master: check that namespace informer cache sync succeeded
f13ccb1 
Signed-off-by: Oleg Zhurakivskyy <oleg.zhurakivskyy@intel.com>
@ozhuraki ozhuraki force-pushed the namespace-lister-check branch from 6e62f62 to f13ccb1 Compare December 2, 2024 10:46
@ozhuraki
Copy link
Contributor Author

ozhuraki commented Dec 2, 2024

@marquiz

Thanks, updated. Please take a look

@ozhuraki ozhuraki requested a review from marquiz December 2, 2024 10:48
marquiz
marquiz approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ozhuraki, looks good to me
/assign @ArangoGutierrez

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marquiz, ozhuraki

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2024
@marquiz
Copy link
Contributor

marquiz commented Dec 4, 2024

/ok-to-test
ping @ArangoGutierrez

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 4, 2024
@marquiz
Copy link
Contributor

marquiz commented Dec 11, 2024

/retest
/assign @fmuyassarov

@marquiz
Copy link
Contributor

marquiz commented Dec 12, 2024

/retest

@marquiz
Copy link
Contributor

marquiz commented Dec 12, 2024

ping @ArangoGutierrez @fmuyassarov

@marquiz
Copy link
Contributor

marquiz commented Dec 12, 2024

/milestone v0.17

@k8s-ci-robot k8s-ci-robot added this to the v0.17 milestone Dec 12, 2024
fmuyassarov
fmuyassarov reviewed Dec 12, 2024
View reviewed changes
Copy link
Member

@fmuyassarov fmuyassarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 12, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2ae13ccd3a99de0c16a1002593b2170cc56c6bc5

@k8s-ci-robot k8s-ci-robot merged commit 1416072 into kubernetes-sigs:master Dec 12, 2024
10 checks passed
@marquiz marquiz mentioned this pull request Dec 20, 2024
Open
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmuyassarov fmuyassarov fmuyassarov left review comments

@marquiz marquiz marquiz approved these changes

Assignees

@ArangoGutierrez ArangoGutierrez

@fmuyassarov fmuyassarov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v0.17
Development

Successfully merging this pull request may close these issues.
5 participants
@ozhuraki @k8s-ci-robot @marquiz @fmuyassarov @ArangoGutierrez