Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts/update-gh-pages: fix release version parsing #1974

Merged

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Dec 12, 2024

When determining the release branch only consider "main" release tags, refusing to pick api/nfd/v* tags.

When determining the release branch only consider "main" release tags,
refusing to pick api/nfd/v* tags.
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 12, 2024
Copy link

netlify bot commented Dec 12, 2024

Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit a416af5
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/675ad03da3021d0008d846b6
😎 Deploy Preview https://deploy-preview-1974--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@marquiz
Copy link
Contributor Author

marquiz commented Dec 12, 2024

Needs to be backported to release-0.16 branch to fix #1971
/cherry-pick release-0.16
/assign @TessaIO

@k8s-infra-cherrypick-robot

@marquiz: once the present PR merges, I will cherry-pick it on top of release-0.16 in a new PR and assign it to you.

In response to this:

Needs to be backported to release-0.16 branch to fix #1971
/cherry-pick release-0.16
/assign @TessaIO

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@marquiz
Copy link
Contributor Author

marquiz commented Dec 12, 2024

/retest

@marquiz
Copy link
Contributor Author

marquiz commented Dec 12, 2024

/assign @ArangoGutierrez

@TessaIO
Copy link
Member

TessaIO commented Dec 12, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 12, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e8d145d5eea4633134e5dfe07250ddc56d42564f

@k8s-ci-robot k8s-ci-robot merged commit 4094da3 into kubernetes-sigs:master Dec 12, 2024
10 checks passed
@k8s-infra-cherrypick-robot

@marquiz: new pull request created: #1975

In response to this:

Needs to be backported to release-0.16 branch to fix #1971
/cherry-pick release-0.16
/assign @TessaIO

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants