Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove errors for nodes without NodeFeatures #1988

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

Kavinraja-G
Copy link
Contributor

@Kavinraja-G Kavinraja-G commented Dec 17, 2024

Fix: #1894

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 17, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 17, 2024
@k8s-ci-robot k8s-ci-robot requested a review from TessaIO December 17, 2024 19:06
@k8s-ci-robot
Copy link
Contributor

Welcome @Kavinraja-G!

It looks like this is your first PR to kubernetes-sigs/node-feature-discovery 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/node-feature-discovery has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @Kavinraja-G. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 17, 2024
Copy link

netlify bot commented Dec 17, 2024

Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit 97345a4
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/67652d1733e7df0008bd6a18
😎 Deploy Preview https://deploy-preview-1988--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Kavinraja-G Kavinraja-G changed the title Remove errors for nodes without nodefeaturerule Remove errors for nodes without NodeFeatures Dec 17, 2024
@marquiz
Copy link
Contributor

marquiz commented Dec 18, 2024

Thank you @Kavinraja-G for the PR. At a quick look this looks like a good fix for the problem. I have to take a more thoughtful look, later.

Have you been able to verify this?
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 18, 2024
@Kavinraja-G
Copy link
Contributor Author

Kavinraja-G commented Dec 18, 2024

Have you been able to verify this?

@marquiz -- Looks like I need to modify the unit tests as well. It expects errors for missing nodeFeatures

@marquiz
Copy link
Contributor

marquiz commented Dec 18, 2024

pkg/apis/nfd/nodefeaturerule/rule.go:222:4: unstructured logging function "Infof" should not be used

@Kavinraja-G Kavinraja-G marked this pull request as ready for review December 18, 2024 11:58
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 18, 2024
@k8s-ci-robot k8s-ci-robot requested a review from zvonkok December 18, 2024 11:58
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 18, 2024
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 18, 2024
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 18, 2024
@Kavinraja-G Kavinraja-G requested a review from marquiz December 18, 2024 14:49
@Kavinraja-G Kavinraja-G requested a review from marquiz December 18, 2024 17:59
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Kavinraja-G for the contribution. This will make logs cleaner and should make users less confused.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Kavinraja-G, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2024
@marquiz
Copy link
Contributor

marquiz commented Dec 18, 2024

/assign @fmuyassarov @TessaIO

@marquiz
Copy link
Contributor

marquiz commented Dec 18, 2024

/assign @ArangoGutierrez

@marquiz
Copy link
Contributor

marquiz commented Dec 19, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 19, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fcf32e36f7ecde79dd8c085837ccb258e5da2c6c

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 19, 2024
@TessaIO
Copy link
Member

TessaIO commented Dec 19, 2024

/lgtm

@marquiz
Copy link
Contributor

marquiz commented Dec 20, 2024

@Kavinraja-G could you rebase this?

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 20, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 20, 2024
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 20, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1f9763911f2db1f72f254473f7c5d688a6e710f9

@k8s-ci-robot k8s-ci-robot merged commit a0a8e3e into kubernetes-sigs:master Dec 20, 2024
10 checks passed
@marquiz marquiz mentioned this pull request Dec 20, 2024
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nfd-master: skip nodes that don't have any NodeFeature objects
6 participants