-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove errors for nodes without NodeFeatures #1988
Remove errors for nodes without NodeFeatures #1988
Conversation
Welcome @Kavinraja-G! |
Hi @Kavinraja-G. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-sigs-nfd ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thank you @Kavinraja-G for the PR. At a quick look this looks like a good fix for the problem. I have to take a more thoughtful look, later. Have you been able to verify this? |
@marquiz -- Looks like I need to modify the unit tests as well. It expects errors for missing nodeFeatures |
|
83f70c7
to
2020523
Compare
ec0341a
to
6b0352a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Kavinraja-G for the contribution. This will make logs cleaner and should make users less confused.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Kavinraja-G, marquiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @fmuyassarov @TessaIO |
/assign @ArangoGutierrez |
/lgtm |
LGTM label has been added. Git tree hash: fcf32e36f7ecde79dd8c085837ccb258e5da2c6c
|
/lgtm |
@Kavinraja-G could you rebase this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 1f9763911f2db1f72f254473f7c5d688a6e710f9
|
Fix: #1894