Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from glide to godep #76

Closed

Conversation

andyxning
Copy link
Contributor

This PR is part of #74 .

This PR keep node-feature-discovery skeleton in sync with kubernetes-template-project.

Note: This PR also migrate vendor management tool from glide to godep.

This PR should be accepted after #75 .
/cc @ConnorDoyle @balajismaniam

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 6, 2017
@andyxning andyxning force-pushed the migrate_from_glide_to_godep branch from 4e0c7f2 to e71e479 Compare September 6, 2017 16:10
@balajismaniam
Copy link
Contributor

@andyxning For graduating to beta, I don't think it is necessary to move from glide to godep. Closing this PR for now.

@andyxning
Copy link
Contributor Author

Make node-feature-discovery's skeleton suitable for an kubernetes repo should be done ASAP, imo.

WDYT @dchen1107 @balajismaniam

@ConnorDoyle
Copy link
Contributor

I think @balajismaniam's point is that the template project is not prescriptive at all about go dependency manager tooling, and therefore isn't relevant to beta graduation.

@andyxning
Copy link
Contributor Author

andyxning commented Sep 8, 2017

@ConnorDoyle

That was my mistake. I mixed two logical different commits into one. The reason for doing this is that as stated in the template project godep is suggested(maybe it is not a strong restrict because moving to glide has actually been discussed in Kubernetes.). But for now, i think it should be ok to be compatible with it. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants