Update k8s version for Client-side throttling on prometheus adapter

[ashishvaishno]

#573

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: ashishvaishno (6b804c4)

[k8s-ci-robot]

Welcome @ashishvaishno!

It looks like this is your first PR to kubernetes-sigs/prometheus-adapter 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/prometheus-adapter has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @ashishvaishno. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ashishvaishno
Once this PR has been reviewed and has the lgtm label, please assign dgrisonnet for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dgrisonnet]

/ok-to-test

[dgrisonnet]

@ashishvaishno could perhaps set the go.mod version to 1.19 and make update-lint?

[ashishvaishno]

@dgrisonnet I tried but I was unsuccessful

golangci-lint run --fix --modules-download-mode=readonly
make: *** [update-lint] Killed: 9

[logicalhan]

/triage accepted

[ashishvaishno]

@logicalhan @dgrisonnet Anything else that needs to be done?

[dgrisonnet]

I am retesting with the newer version of Go just in case, but there seems to be a problem with our linter. I'll try to have a look at it when I have some times on my hands.

/retest

[ashishvaishno]

@dgrisonnet Any updates :)

[dims]

/retest

[dims]

/assign @dgrisonnet

[dims]

Hmm, the PR as is ... is failing for sure (3 🔴 CI jobs)

I am looking for a fix for:
#581

Which was fixed only in 1.26.4 of kubernetes:

• kubernetes/kubernetes@67e6297
• kubernetes/kubernetes@67e6297

So i can try to file another PR?

[dgrisonnet]

Sorry for the delay folks, I was out most of May. I'll create a PR bumping everything and it will most likely fix the issue with 1.27.

[dims]

thanks @dgrisonnet

[booleanbetrayal]

Thanks @dgrisonnet! Also experiencing upgrade failures in v1.27 stemming from this issue.

[dgrisonnet]

/retest

[k8s-ci-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dgrisonnet]

Closing since #586 was merged.

[k8s-ci-robot]

@ashishvaishno: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-prometheus-adapter-test	cd60817	link	true	/test pull-prometheus-adapter-test
pull-prometheus-adapter-verify	cd60817	link	true	/test pull-prometheus-adapter-verify
pull-prometheus-adapter-test-e2e	cd60817	link	true	/test pull-prometheus-adapter-test-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.