Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for OpenAPI v3 #589

Closed
wants to merge 1 commit into from
Closed

Add support for OpenAPI v3 #589

wants to merge 1 commit into from

Conversation

dgrisonnet
Copy link
Member

No description provided.

@dgrisonnet
cmd/adapter: add support for openapi v3
c312fb9 
Signed-off-by: Damien Grisonnet <dgrisonn@redhat.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 22, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgrisonnet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 22, 2023
@dgrisonnet
Copy link
Member Author

/triage accepted
/assign @olivierlemasle

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 22, 2023
@dgrisonnet dgrisonnet mentioned this pull request Jun 22, 2023
Merged
dgrisonnet
dgrisonnet commented Jun 22, 2023
View reviewed changes
cmd/adapter/adapter.go
@@ -292,15 +294,23 @@ func main() {
}
cmd.Name = "prometheus-metrics-adapter"

cmd.OpenAPIConfig = genericapiserver.DefaultOpenAPIConfig(generatedopenapi.GetOpenAPIDefinitions, openapinamer.NewDefinitionNamer(api.Scheme, customexternalmetrics.Scheme))
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flag initialization need to happen before the OpenAPI configuration since it can be set by the users via a CLI flag.

@k8s-ci-robot
Copy link
Contributor

@dgrisonnet: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-prometheus-adapter-test-e2e c312fb9 link true /test pull-prometheus-adapter-test-e2e
pull-prometheus-adapter-verify c312fb9 link true /test pull-prometheus-adapter-verify
pull-prometheus-adapter-test c312fb9 link true /test pull-prometheus-adapter-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dgrisonnet
Copy link
Member Author

This need newer versions of custom-metrics-apiserver so I'll just move the change to #586.

@dgrisonnet dgrisonnet closed this Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivierlemasle olivierlemasle Awaiting requested review from olivierlemasle

Assignees

@olivierlemasle olivierlemasle

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dgrisonnet @k8s-ci-robot @olivierlemasle