-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support to dynamically discover metrics configs across all namespaces in the cluster #669
base: master
Are you sure you want to change the base?
Adding support to dynamically discover metrics configs across all namespaces in the cluster #669
Conversation
…espaces in the cluster
|
Welcome @ramasai1! |
Hi @ramasai1. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ramasai1 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
It'd be great if the adapter could dynamically discover metrics configurations across all namespaces in the cluster. This would be helpful in scenarios where application developers can add Prometheus rules for HPA in their Helm chart without needing to touch the adapter configuration.
A similar ask is present in #662, but I've chosen to add support using
ConfigMap
since the adapter already uses that instead of adding a new CRD.