Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix SplitByKnownRegistries #189

Merged
merged 2 commits into from
Mar 5, 2020
Merged

fix SplitByKnownRegistries #189

merged 2 commits into from
Mar 5, 2020

Conversation

listx
Copy link
Contributor

@listx listx commented Mar 5, 2020

This should fix #188

/cc @thockin @dims

@k8s-ci-robot k8s-ci-robot requested review from dims and thockin March 5, 2020 01:36
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/release Categorizes an issue or PR as relevant to SIG Release. labels Mar 5, 2020
@dims
Copy link
Member

dims commented Mar 5, 2020

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 5, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, listx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@listx listx changed the title Fix auditor fix SplityByKnownRegistries Mar 5, 2020
@listx listx changed the title fix SplityByKnownRegistries fix SplitByKnownRegistries Mar 5, 2020
@k8s-ci-robot k8s-ci-robot merged commit d677a55 into kubernetes-sigs:master Mar 5, 2020
listx pushed a commit to listx/k8s.io that referenced this pull request Mar 5, 2020
promote promoter
d6d301b 
Included fixes:

kubernetes-sigs/promo-tools#187
kubernetes-sigs/promo-tools#189
@listx listx mentioned this pull request Mar 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims Awaiting requested review from dims

@thockin thockin Awaiting requested review from thockin

Assignees

@dims dims

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cip: fix fatal bug in SplitByKnownRegistries
3 participants
@listx @dims @k8s-ci-robot