Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a plan struct inside organization #333

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

hector-vido
Copy link
Contributor

@hector-vido hector-vido commented Nov 29, 2024

GitHub no longer allows branch-protection to be set via the API on private repos using the free plan, we need to know the plan type to apply customized logic for some automation we have.

The plan property is described on https://docs.github.com/en/rest/orgs/orgs?apiVersion=2022-11-28#get-an-organization

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 29, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @hector-vido!

It looks like this is your first PR to kubernetes-sigs/prow 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/prow has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 29, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @hector-vido. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 29, 2024
Copy link

netlify bot commented Nov 29, 2024

Deploy Preview for k8s-prow ready!

Name Link
🔨 Latest commit 588abad
🔍 Latest deploy log https://app.netlify.com/sites/k8s-prow/deploys/6749b4d891f0e50008435519
😎 Deploy Preview https://deploy-preview-333--k8s-prow.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hector-vido
Copy link
Contributor Author

cc @droslean

@droslean
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 29, 2024
@droslean
Copy link
Contributor

/retest

1 similar comment
@droslean
Copy link
Contributor

droslean commented Dec 1, 2024

/retest

@smg247
Copy link
Contributor

smg247 commented Dec 2, 2024

/lgtm

We will likely also need to add this perm to our GH app post-merge. From the linked doc:

To see information about an organization's GitHub plan, GitHub Apps need the Organization plan permission.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 2, 2024
@smg247
Copy link
Contributor

smg247 commented Dec 2, 2024

FYI, the integration test failures aren't related to this PR. I do wonder what is going on though...

==> Creating KIND cluster
/home/prow/go/src/github.com/kubernetes-sigs/prow/test/integration/setup-kind-cluster.sh: line 119: kind: command not found

Maybe this change: https://github.com/kubernetes/test-infra/pull/33847/files#diff-f90aeb8ab7950a007a7d1b405ac1c4f0be6abb143aa868c2b94e6a18390a5474

Let's see: kubernetes/test-infra#33847 (comment)

@droslean
Copy link
Contributor

droslean commented Dec 2, 2024

/retest

1 similar comment
@droslean
Copy link
Contributor

droslean commented Dec 3, 2024

/retest

@droslean
Copy link
Contributor

droslean commented Dec 3, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: droslean, hector-vido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2024
@k8s-ci-robot k8s-ci-robot merged commit f9126b3 into kubernetes-sigs:main Dec 3, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants