Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split Verify API into VerifyImage and VerifyFile #32

Merged
merged 1 commit into from
Feb 8, 2022
Merged

Split Verify API into VerifyImage and VerifyFile #32

merged 1 commit into from
Feb 8, 2022

Conversation

PushkarJ
Copy link
Member

@PushkarJ PushkarJ commented Feb 8, 2022

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 8, 2022
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 8, 2022
@PushkarJ PushkarJ changed the title Split Verify API into VerifyImage and VerifyFile` Split Verify API into VerifyImage and VerifyFile Feb 8, 2022
@PushkarJ
Copy link
Member Author

PushkarJ commented Feb 8, 2022

/sig security

@k8s-ci-robot k8s-ci-robot added the sig/security Categorizes an issue or PR as relevant to SIG Security. label Feb 8, 2022
@PushkarJ PushkarJ changed the title Split Verify API into VerifyImage and VerifyFile WIP: Split Verify API into VerifyImage and VerifyFile Feb 8, 2022
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 8, 2022
@PushkarJ PushkarJ changed the title WIP: Split Verify API into VerifyImage and VerifyFile Split Verify API into VerifyImage and VerifyFile Feb 8, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 8, 2022
puerco
puerco approved these changes Feb 8, 2022
View reviewed changes
Copy link
Member

@puerco puerco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @PushkarJ , let's remember to complete the Verify tests when we are done.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 8, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: puerco, PushkarJ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2022
@k8s-ci-robot k8s-ci-robot merged commit 2abb0c6 into kubernetes-sigs:main Feb 8, 2022
@saschagrunert saschagrunert mentioned this pull request Feb 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@puerco puerco puerco approved these changes

@xmudrii xmudrii Awaiting requested review from xmudrii

Assignees

@puerco puerco

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/security Categorizes an issue or PR as relevant to SIG Security. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PushkarJ @k8s-ci-robot @puerco