Make attaching image signature optional #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces an option to control if signatures get attached to images after signing. It may be the case that we need to store the signature or attach it at a different time. Signed-off-by: Adolfo García Veytia (Puerco) <adolfo.garcia@uservers.net>
k8s-ci-robot
added
kind/feature
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, puerco The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This commit introduces an option to control if signatures get
attached to images after signing. It may be the case that we
need to store the signature or attach it at a different time.
Signed-off-by: Adolfo García Veytia (Puerco) adolfo.garcia@uservers.net
Which issue(s) this PR fixes:
Part of kubernetes/release#2383
Special notes for your reviewer:
Most likely we will have to attach the signatures in the image promoter outside of cosign
as one identity signs and another promotes. So we need to make attaching it from the
signer optional to avoid an error when the signer is not authorized to push.
/assign @cpanato @saschagrunert
/cc @kubernetes-sigs/release-engineering
Does this PR introduce a user-facing change?