return the git version from the one that is passed from the ldflags due to an issue in upstream #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ue to an issue in upstream Signed-off-by: cpanato <ctadeu@gmail.com>
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
sig/release
k8s-ci-robot
added
approved
saschagrunert
approved these changes
Jun 13, 2022
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
the
debug.ReadBuildInfo()works for most of the parameters we use, but for the git version it is always returning(devel), so we need to continue passing theldflagsfor the gitversion until the issue golang/go#29228 is addressed./assign @saschagrunert @xmudrii @palnabarun @Verolop
cc @kubernetes-sigs/release-engineering
we will need a patch release for this as well
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?