Allow the override of all version package variables
#61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This now makes it possible to override all variables via the `-X`
ldflag, for example:
```go
package main
import (
"fmt"
"sigs.k8s.io/release-utils/version"
)
func main() {
v := version.GetVersionInfo()
fmt.Print(v.String())
}
```
```
> go run -ldflags '\
-X sigs.k8s.io/release-utils/version.gitVersion=1 \
-X sigs.k8s.io/release-utils/version.gitCommit=2 \
-X sigs.k8s.io/release-utils/version.gitTreeState=3 \
-X sigs.k8s.io/release-utils/version.buildDate=4 \
-X sigs.k8s.io/release-utils/version.goVersion=5 \
-X sigs.k8s.io/release-utils/version.compiler=6 \
-X sigs.k8s.io/release-utils/version.platform=7' \
main.go
GitVersion: 1
GitCommit: 2
GitTreeState: 3
BuildDate: 4
GoVersion: 5
Compiler: 6
Platform: 7
```
Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
k8s-ci-robot
added
kind/feature
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
sig/release
k8s-ci-robot
added
approved
|
Nice. Im happy with this as is, but another option would be to use buildinfo first and if its empty use the vars |
cpanato
reviewed
Jul 21, 2022
k8s-ci-robot
added
the
lgtm
|
@cpanato yes, do you wanna take care of that? |
will do! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This now makes it possible to override all variables via the
-Xldflag, for example:Which issue(s) this PR fixes:
Fixes #59
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?