Add CompressWithoutPreservingPath to tar package #83
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
The default way the
tar.Compress
function works is that we preserve the path betweentarFilePath
andtarContentsPath
directories inside the archive.This might not work well if
tarFilePath
andtarContentsPath
are on different levels in the file system (e.g. they don't have a common parent directory). In such case we can disablepreserveRootDirStructure
flag which will make paths inside the archive relative totarContentsPath
.The test case of this newly-added function describes what I'm trying to accomplish.
Special notes for your reviewer:
I don't like
CompressWithoutPreservingPath
function name and I'm very welcome to any ideas. 🙃Does this PR introduce a user-facing change?
/assign @saschagrunert @cpanato
cc @kubernetes-sigs/release-engineering