Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure bin-packing in Helm chart #448

Closed
asm582 opened this issue Nov 11, 2022 · 6 comments
Closed

Configure bin-packing in Helm chart #448

asm582 opened this issue Nov 11, 2022 · 6 comments
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@asm582
Copy link

asm582 commented Nov 11, 2022

Hello,

Any pointers on how to enable packing? I read kubernetes has bin-packing, how do we use such plugins in co-scheduler using helm commands?

@asm582
Copy link
Author

asm582 commented Nov 11, 2022

@Huang-Wei Sorry for tagging, any pointers that you can share would be of great help, and do you think should packing be enabled by default?

@Huang-Wei
Copy link
Contributor

Bin-packing can be achieved by configuring the in-tree RequestedToCapacityRatio plugin, generally, it should work using the following config:

  plugins:
    score:
      enabled:
      - name: RequestedToCapacityRatio
        weight: 10 # a user-defined weight
      disabled:
      - name: NodeResourcesLeastAllocated
  pluginConfig:
  - name: RequestedToCapacityRatio
    args:
      shape:
      - utilization: 0
        score: 0
      - utilization: 100
        score: 10
      # resources: # without explicitly defining resources, the above config will apply to cpu and memory

Please note that it's tangant with enabling co-scheduling (or whatever other plugin) or not. It's just a standalone plugin that favors nodes with higher resource utilization than others.

I don't have cycles to look into how to reflect the config into Helm charts, but it's doable. Help is wanted.

/help

@k8s-ci-robot
Copy link
Contributor

@Huang-Wei:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

Bin-packing can be achieved by configuring the in-tree RequestedToCapacityRatio plugin, generally, it should work using the following config:

 plugins:
   score:
     enabled:
     - name: RequestedToCapacityRatio
       weight: 10 # a user-defined weight
     disabled:
     - name: NodeResourcesLeastAllocated
 pluginConfig:
 - name: RequestedToCapacityRatio
   args:
     shape:
     - utilization: 0
       score: 0
     - utilization: 100
       score: 10
     # resources: # without explicitly defining resources, the above config will apply to cpu and memory

Please note that it's tangant with enabling co-scheduling (or whatever other plugin) or not. It's just a standalone plugin that favors nodes with higher resource utilization than others.

I don't have cycles to look into how to reflect the config into Helm charts, but it's doable. Help is wanted.

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Nov 17, 2022
@Huang-Wei Huang-Wei changed the title [Co-scheduler] Enable packing in co-scheduler Configure bin-packing in Helm chart Nov 17, 2022
@Gekko0114
Copy link
Member

I will try to investigate if no one else is going to do it.
/assign

@Huang-Wei
Copy link
Contributor

I should have commented that it's not planned to support it in scheduler-plugins. (and hence removed the /help label)

The reason is that bin-packing is supported via one of the in-tree plugins, so the problem domain applies to the upstream default-scheduler, instead of any scheduler plugin that adopts it.

/close not-planned

@k8s-ci-robot k8s-ci-robot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 6, 2023
@k8s-ci-robot
Copy link
Contributor

@Huang-Wei: Closing this issue, marking it as "Not Planned".

In response to this:

I should have commented that it's not planned to support it in scheduler-plugins. (and hence removed the /help label)

The reason is that bin-packing is supported via one of the in-tree plugins, so the problem domain applies to the upstream default-scheduler, instead of any scheduler plugin that adopts it.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants