Update install doc to match release v0.19.8 #163

Huang-Wei · 2021-03-16T19:45:44Z

Part of #161.

Updated the installation doc to match release v0.19.8.

Fixes #150.

Huang-Wei · 2021-03-16T19:46:49Z

cc @seanmalloy @xq2005

/assign @cwdsuzhou @denkensk

Huang-Wei · 2021-03-16T19:49:41Z

doc/install.md

+      scheduleTimeoutSeconds: 10
+    ```
+
+    << UNSOLVED >>: It's expected to get `status` in the above yaml. Needs debug.


@cwdsuzhou @denkensk could you help investigate why the status is not displayed? Better to compare the RBAC/CRD with your production settings.

After appending the 2nd commit, a PodGroup with matching Pods can display its status, but still empty for a PodGroup without any matching Pods.

Huang-Wei · 2021-03-16T19:51:23Z

manifests/install/all-in-one.yaml

@@ -0,0 +1,83 @@
+# First part


@cwdsuzhou @denkensk could you help compare the RBAC/CRD with your production settings? to ensure the correctness and the privileges are not over-exposed. Thanks in advance.

Hi, coscheduling works ok in my cluster using the the RBAC(changed in this PR) and CRD

Since pod group controller is not necessary now, we did not deploy in our production environment.

I verified it in my test environment, when I deployed the controller, the status changed.

Huang-Wei · 2021-03-16T20:17:15Z

/hold

manifests/install/all-in-one.yaml

cwdsuzhou · 2021-03-17T02:08:57Z

manifests/install/all-in-one.yaml

+  resources: ["pods"]
+  verbs: ["get", "list", "watch"]
+- apiGroups: ["scheduling.sigs.k8s.io"]
+  resources: ["podgroups", "podgroups/status", "elasticquotas", "elasticquotas/status"]


we have not enabled status subresource of podgroup, so podgroups/status is not necessary

thanks. Could you help verify that when a PodGroup is created (without any matching pods), is its status displayed properly?

Updated: after I updated controller SA's rbac setting (replace Update with Patch), it shows properly. But it's not showing the number:

... spec: minMember: 3 scheduleTimeoutSeconds: 10 status: phase: Pending

And if I create a deployment with 2 pods, the phase gets changed to PreScheduling, but if I delete the deployment, its phase stays in PreScheduling (I'd expect it to be updated back to Pending)

And if I create a deployment with 2 pods, the phase gets changed to PreScheduling, but if I delete the deployment, its phase stays in PreScheduling (I'd expect it to be updated back to Pending)

This may be a bug the status would not be back to Pending

This may be a bug the status would not be back to Pending

I will create an issue tracking this.

BTW: could you help confirm this issue:

after I updated controller SA's rbac setting (replace Update with Patch), it shows properly. But it's not showing the number:

In my test environment, as I showed #163 (comment), we can see number.

The controller is deployed based on the manifests in this PR

Created #166 to track the UX issues.

cwdsuzhou · 2021-03-17T04:57:25Z

/lgtm

k8s-ci-robot · 2021-03-17T04:58:22Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cwdsuzhou, Huang-Wei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [Huang-Wei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

doc/install.md

Huang-Wei · 2021-03-19T20:20:09Z

Commits squashed and some UX issues are tracked in #166. Please take another look.

/hold cancel

Huang-Wei · 2021-03-22T17:42:28Z

@cwdsuzhou would you minding re-lgtm?

seanmalloy · 2021-03-23T04:30:15Z

doc/install.md

+[install doc](https://github.com/kubernetes-sigs/scheduler-plugins/blob/release-1.19/doc/install.md) in
+branch `release-1.19`.


Suggested change

[install doc](https://github.com/kubernetes-sigs/scheduler-plugins/blob/release-1.19/doc/install.md) in

branch `release-1.19`.

[install doc](https://github.com/kubernetes-sigs/scheduler-plugins/blob/release-1.18/doc/install.md) in

branch `release-1.18`.

Thanks for the catch. I put this paragraph into a section Instal lower-version releases.

seanmalloy · 2021-03-23T05:10:06Z

/kind documentation

seanmalloy · 2021-03-23T05:57:44Z

/lgtm
/hold

Adding a hold so that @cwdsuzhou can review one more time before merge. Please feel free to remove the hold once you are ready for this to merge. Thanks!

Huang-Wei · 2021-03-23T23:00:33Z

Kindly ping @@cwdsuzhou for taking another look.

cwdsuzhou · 2021-03-24T03:19:20Z

doc/install.md

+    ```
+
+1. Create a deploy labelled `pod-group.scheduling.sigs.k8s.io: pg1` to associated with PodGroup
+   `pg1` created in the previous step.


always get 1., seems not intentional

When the list is long and frequently modified, it's not easy to always make its numbers ordered accurately :) So keep all as 1. and make them indented well, markdown will do the rest things.

cwdsuzhou · 2021-03-24T03:22:18Z

minor hits. Otherwise, lgtm

Huang-Wei · 2021-03-24T05:16:24Z

/hold cancel

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 16, 2021

k8s-ci-robot requested review from seanmalloy and yuanchen8911 March 16, 2021 19:45

k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 16, 2021

k8s-ci-robot assigned cwdsuzhou and denkensk Mar 16, 2021

Huang-Wei mentioned this pull request Mar 16, 2021

Update doc reference to v1alpha2 scheduler config API #147

Closed

Huang-Wei commented Mar 16, 2021

View reviewed changes

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 16, 2021

Huang-Wei commented Mar 17, 2021

View reviewed changes

manifests/install/all-in-one.yaml Outdated Show resolved Hide resolved

cwdsuzhou reviewed Mar 17, 2021

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 17, 2021

cwdsuzhou approved these changes Mar 17, 2021

View reviewed changes

cwdsuzhou reviewed Mar 17, 2021

View reviewed changes

doc/install.md Show resolved Hide resolved

Huang-Wei force-pushed the install-doc-update branch from 79623ef to 9bf85d9 Compare March 19, 2021 20:18

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 19, 2021

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 19, 2021

seanmalloy reviewed Mar 23, 2021

View reviewed changes

k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Mar 23, 2021

Update install doc to match release v0.19.8

f6ed233

Huang-Wei force-pushed the install-doc-update branch from 9bf85d9 to f6ed233 Compare March 23, 2021 05:27

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 23, 2021

k8s-ci-robot assigned seanmalloy Mar 23, 2021

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 23, 2021

cwdsuzhou reviewed Mar 24, 2021

View reviewed changes

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 24, 2021

k8s-ci-robot merged commit c12f81e into kubernetes-sigs:master Mar 24, 2021

Huang-Wei deleted the install-doc-update branch March 24, 2021 05:32

seanmalloy mentioned this pull request Apr 2, 2021

User Documentation for deploying scheduler plugins #89

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update install doc to match release v0.19.8 #163

Update install doc to match release v0.19.8 #163

Huang-Wei commented Mar 16, 2021 •

edited

Loading

Huang-Wei commented Mar 16, 2021

Huang-Wei Mar 16, 2021

Huang-Wei Mar 17, 2021

Huang-Wei Mar 16, 2021

cwdsuzhou Mar 17, 2021 •

edited

Loading

Huang-Wei commented Mar 16, 2021

cwdsuzhou Mar 17, 2021

Huang-Wei Mar 17, 2021 •

edited

Loading

cwdsuzhou Mar 17, 2021

Huang-Wei Mar 17, 2021

cwdsuzhou Mar 17, 2021

Huang-Wei Mar 19, 2021

cwdsuzhou commented Mar 17, 2021

k8s-ci-robot commented Mar 17, 2021

Huang-Wei commented Mar 19, 2021

Huang-Wei commented Mar 22, 2021

seanmalloy Mar 23, 2021

Huang-Wei Mar 23, 2021

seanmalloy commented Mar 23, 2021

seanmalloy commented Mar 23, 2021

Huang-Wei commented Mar 23, 2021

cwdsuzhou Mar 24, 2021

Huang-Wei Mar 24, 2021

cwdsuzhou commented Mar 24, 2021

Huang-Wei commented Mar 24, 2021

		[install doc](https://github.com/kubernetes-sigs/scheduler-plugins/blob/release-1.19/doc/install.md) in
		branch `release-1.19`.

Update install doc to match release v0.19.8 #163

Update install doc to match release v0.19.8 #163

Conversation

Huang-Wei commented Mar 16, 2021 • edited Loading

Huang-Wei commented Mar 16, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cwdsuzhou Mar 17, 2021 • edited Loading

Choose a reason for hiding this comment

Huang-Wei commented Mar 16, 2021

Choose a reason for hiding this comment

Huang-Wei Mar 17, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cwdsuzhou commented Mar 17, 2021

k8s-ci-robot commented Mar 17, 2021

Huang-Wei commented Mar 19, 2021

Huang-Wei commented Mar 22, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

seanmalloy commented Mar 23, 2021

seanmalloy commented Mar 23, 2021

Huang-Wei commented Mar 23, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cwdsuzhou commented Mar 24, 2021

Huang-Wei commented Mar 24, 2021

Huang-Wei commented Mar 16, 2021 •

edited

Loading

cwdsuzhou Mar 17, 2021 •

edited

Loading

Huang-Wei Mar 17, 2021 •

edited

Loading