-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chart: use release.namespace to specify target ns #519
Conversation
Signed-off-by: Wei Zhang <kweizh@gmail.com>
Hi @zwpaper. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
I verified in a kind 1.25 env:
|
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Huang-Wei, zwpaper The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Do we need to add some note in |
Hi @czybjtu, yes, we need the doc to be updated aligning with the new installation mechanism, it is appreciated that you found it, could you like to raise a PR for the update? |
What type of PR is this?
What this PR does / why we need it:
currently, we let users set the scheduler and controller namespace respectively in
values.yaml
, and only create the controller's namespace in templates.but helm can manager namespace by
--create-namespace
and--namespace
args,we should leverage helm's namespace management ability.
this PR:
.Release.Namespace
Which issue(s) this PR fixes:
Fixes # #420
Special notes for your reviewer:
Does this PR introduce a user-facing change?