Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chart: use release.namespace to specify target ns #519

Merged
merged 1 commit into from
Mar 3, 2023

Conversation

zwpaper
Copy link
Member

@zwpaper zwpaper commented Feb 18, 2023

What type of PR is this?

What this PR does / why we need it:

currently, we let users set the scheduler and controller namespace respectively in values.yaml, and only create the controller's namespace in templates.

but helm can manager namespace by --create-namespace and --namespace args,
we should leverage helm's namespace management ability.

this PR:

  1. drop the controller namespace in templates
  2. let helm to manager the target namespace by using .Release.Namespace
  3. use the same namespace for the controller and secondary scheduler

Which issue(s) this PR fixes:

Fixes # #420

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Support custom namespace installation in Helm Chart

Signed-off-by: Wei Zhang <kweizh@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 18, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @zwpaper. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 18, 2023
@denkensk
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 20, 2023
@Huang-Wei
Copy link
Contributor

Huang-Wei commented Mar 3, 2023

I verified in a kind 1.25 env:

⇒  helm install scheduler-plugins manifests/install/charts/as-a-second-scheduler/ --create-namespace --namespace foo
⇒  k get po -n foo
NAME                                            READY   STATUS    RESTARTS   AGE
scheduler-plugins-controller-58987f447f-jshdl   1/1     Running   0          39s
scheduler-plugins-scheduler-5756bc7f87-lzdj9    1/1     Running   0          39s
⇒  k get crd
NAME                                              CREATED AT
appgroups.appgroup.diktyo.k8s.io                  2023-03-03T01:21:25Z
elasticquotas.scheduling.sigs.k8s.io              2023-03-03T01:21:25Z
networktopologies.networktopology.diktyo.k8s.io   2023-03-03T01:21:25Z
noderesourcetopologies.topology.node.k8s.io       2023-03-03T01:21:25Z
podgroups.scheduling.sigs.k8s.io                  2023-03-03T01:21:25Z

@Huang-Wei
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Huang-Wei, zwpaper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 3, 2023
@k8s-ci-robot k8s-ci-robot merged commit a54c412 into kubernetes-sigs:master Mar 3, 2023
@nayihz
Copy link
Contributor

nayihz commented Mar 3, 2023

Do we need to add some note in https://github.com/kubernetes-sigs/scheduler-plugins/blob/master/manifests/install/charts/as-a-second-scheduler/README.md#installing-the-chart ?

@zwpaper
Copy link
Member Author

zwpaper commented Mar 3, 2023

Hi @czybjtu, yes, we need the doc to be updated aligning with the new installation mechanism, it is appreciated that you found it, could you like to raise a PR for the update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants