Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] test commit to verify presubmits still work #775

Closed
wants to merge 1 commit into from

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Oct 5, 2021

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 5, 2021
@k8s-ci-robot k8s-ci-robot requested review from ritazh and tam7t October 5, 2021 22:37
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: spiffxp
To complete the pull request process, please assign ritazh after the PR has been reviewed.
You can assign the PR to them by writing /assign @ritazh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 5, 2021
@aramase
Copy link
Member

aramase commented Oct 5, 2021

/test pull-secrets-store-csi-driver-e2e-windows

@spiffxp
Copy link
Member Author

spiffxp commented Oct 5, 2021

I can't quite tell what the exact failure is for pull-secrets-store-csi-driver-e2e-windows but it looks like it was able to build images which I believe was the blocker earlier

I know pull-secrets-store-csi-driver-image-scan was another job that was blocked on docker build failing, and that seems to have worked fine, ref: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_secrets-store-csi-driver/775/pull-secrets-store-csi-driver-image-scan/1445518438641438720

At this point I'm satisfied the MTU workaround is no longer needed but I'll leave this open for the job triggered in #775 (comment) to finish

@aramase
Copy link
Member

aramase commented Oct 5, 2021

At this point I'm satisfied the MTU workaround is no longer needed but I'll leave this open for the job triggered in #775 (comment) to finish

@spiffxp All the tests passed! thanks for validating it.

@spiffxp
Copy link
Member Author

spiffxp commented Oct 6, 2021

/close

@k8s-ci-robot
Copy link
Contributor

@spiffxp: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants