-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add imagePullSecrets property to SPOD configuration #1227
Add imagePullSecrets property to SPOD configuration #1227
Conversation
Hi @ccojocar. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1227 +/- ##
==========================================
- Coverage 45.42% 45.41% -0.01%
==========================================
Files 48 48
Lines 5361 5362 +1
==========================================
Hits 2435 2435
- Misses 2806 2807 +1
Partials 120 120 |
/ok-to-test |
CI is not happy with the TOC:
|
953f3f8
to
21aa1dd
Compare
/test e2e-fedora |
@ccojocar: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test pull-security-profiles-operator-test-e2e |
/test all |
29e65ca
to
8837270
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, too
Thanks @jhrozek for review, @saschagrunert Can we merge this now? Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/unhold
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ccojocar, jhrozek, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind api-change
What this PR does / why we need it:
Adds the
imagePullSecrets
property to SPOD configuration. This is required to pull the images from spod pod from a private registry. For instance when these images are mirrored in a private registry instead of using them from public registry.Which issue(s) this PR fixes:
Does this PR have test?
Special notes for your reviewer:
Does this PR introduce a user-facing change?