Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use directly the box url instead of the metadata when downloading the vagrant box for flatcar linux #1252

Merged

Conversation

ccojocar
Copy link
Contributor

@ccojocar ccojocar commented Oct 21, 2022

What type of PR is this?

/kind bug

What this PR does / why we need it:

It seems that vagrant resolve the relative path from the vagrant metadata to a local file path instead of URL.

See the URL in the metadata file https://lts.release.flatcar-linux.net/amd64-usr/current/flatcar_production_vagrant.json
This gets resolved to a file:// instead to a url:// due to https://github.com/hashicorp/vagrant/blob/87689f5f196cf31dea057eb91aa34a09949ebc8a/lib/vagrant/action/builtin/box_add.rb#L412.
It seems that there is not way to configure this currently.

Which issue(s) this PR fixes:

Does this PR have test?

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fix integration tests for Flatcar Linux.

… vagrant box for flatcar linux

It seems that vegrant resolve the relative path from the vagrant metadata to a local file path instead of URL.

See the URL in the metadata file https://lts.release.flatcar-linux.net/amd64-usr/current/flatcar_production_vagrant.json
This gets resolved to a file:// instead to a url:// due to https://github.com/hashicorp/vagrant/blob/87689f5f196cf31dea057eb91aa34a09949ebc8a/lib/vagrant/action/builtin/box_add.rb#L412.
It seems that there is not way to configure this currently.
@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 21, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @ccojocar. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 21, 2022
@k8s-ci-robot k8s-ci-robot requested review from JAORMX and pjbgf October 21, 2022 09:08
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 21, 2022
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 21, 2022
@JAORMX
Copy link
Contributor

JAORMX commented Oct 21, 2022

/lgtm cancel

let's wait for the flatcar job to pass first.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 21, 2022
@ccojocar
Copy link
Contributor Author

@saschagrunert This should fix the flatcar integration test.

@jhrozek jhrozek mentioned this pull request Oct 21, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 21, 2022
@saschagrunert saschagrunert merged commit 76c72b0 into kubernetes-sigs:main Oct 21, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ccojocar, JAORMX, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JAORMX,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants