-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use directly the box url instead of the metadata when downloading the vagrant box for flatcar linux #1252
Use directly the box url instead of the metadata when downloading the vagrant box for flatcar linux #1252
Conversation
… vagrant box for flatcar linux It seems that vegrant resolve the relative path from the vagrant metadata to a local file path instead of URL. See the URL in the metadata file https://lts.release.flatcar-linux.net/amd64-usr/current/flatcar_production_vagrant.json This gets resolved to a file:// instead to a url:// due to https://github.com/hashicorp/vagrant/blob/87689f5f196cf31dea057eb91aa34a09949ebc8a/lib/vagrant/action/builtin/box_add.rb#L412. It seems that there is not way to configure this currently.
Hi @ccojocar. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm cancel let's wait for the flatcar job to pass first. |
@saschagrunert This should fix the flatcar integration test. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ccojocar, JAORMX, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
It seems that vagrant resolve the relative path from the vagrant metadata to a local file path instead of URL.
See the URL in the metadata file https://lts.release.flatcar-linux.net/amd64-usr/current/flatcar_production_vagrant.json
This gets resolved to a file:// instead to a url:// due to https://github.com/hashicorp/vagrant/blob/87689f5f196cf31dea057eb91aa34a09949ebc8a/lib/vagrant/action/builtin/box_add.rb#L412.
It seems that there is not way to configure this currently.
Which issue(s) this PR fixes:
Does this PR have test?
Special notes for your reviewer:
Does this PR introduce a user-facing change?