Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add direclty the file header of generated mocks #1295

Merged
merged 7 commits into from
Nov 12, 2022

Conversation

ccojocar
Copy link
Contributor

@ccojocar ccojocar commented Nov 11, 2022

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Adds directly the file header of the generated mocks instead of doing post processing which cased duplicated header on macos.

Which issue(s) this PR fixes:

This allow to run the make verify command on macos during development. The current implementation generates a duplicated header which causes a dirty tree.

Does this PR have test?

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Add directly the file header when generating the mock types.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 11, 2022
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 11, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1295 (991330e) into main (868709e) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1295   +/-   ##
=======================================
  Coverage   43.92%   43.92%           
=======================================
  Files          49       49           
  Lines        5514     5514           
=======================================
  Hits         2422     2422           
  Misses       2972     2972           
  Partials      120      120           

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ccojocar, JAORMX

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 11, 2022
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 11, 2022
@ccojocar
Copy link
Contributor Author

@JAORMX Please could you lgtm again this pull request? Thanks

@pjbgf
Copy link
Member

pjbgf commented Nov 12, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 12, 2022
@k8s-ci-robot k8s-ci-robot merged commit fcb0acd into kubernetes-sigs:main Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants