-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add direclty the file header of generated mocks #1295
Add direclty the file header of generated mocks #1295
Conversation
go:generate doesn't allow a command to span multiple lines.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1295 +/- ##
=======================================
Coverage 43.92% 43.92%
=======================================
Files 49 49
Lines 5514 5514
=======================================
Hits 2422 2422
Misses 2972 2972
Partials 120 120 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ccojocar, JAORMX The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@JAORMX Please could you lgtm again this pull request? Thanks |
/lgtm |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Adds directly the file header of the generated mocks instead of doing post processing which cased duplicated header on macos.
Which issue(s) this PR fixes:
This allow to run the
make verify
command on macos during development. The current implementation generates a duplicated header which causes a dirty tree.Does this PR have test?
Special notes for your reviewer:
Does this PR introduce a user-facing change?