Fix bundle goal into the Makefile for macos #1300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/release-note-label-needed
k8s-ci-robot
added
size/XS
ccojocar
force-pushed
the
fix_bundle_generator_macos
branch
from
c7fec73 to
b8de26e
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1300 +/- ##
==========================================
+ Coverage 43.92% 44.07% +0.14%
==========================================
Files 49 49
Lines 5514 5566 +52
==========================================
+ Hits 2422 2453 +31
- Misses 2972 2994 +22
+ Partials 120 119 -1 |
saschagrunert
approved these changes
Nov 14, 2022
k8s-ci-robot
added
lgtm
|
/test all |
ccojocar
force-pushed
the
fix_bundle_generator_macos
branch
from
b8de26e to
6975a3a
Compare
k8s-ci-robot
removed
the
lgtm
JAORMX
approved these changes
Nov 14, 2022
k8s-ci-robot
added
the
lgtm
|
/test all |
|
/retest |
k8s-ci-robot
removed
the
lgtm
ccojocar
force-pushed
the
fix_bundle_generator_macos
branch
from
49887e4 to
6975a3a
Compare
|
/retest |
1 similar comment
|
/retest |
|
/test all |
ccojocar
force-pushed
the
fix_bundle_generator_macos
branch
from
49de0b7 to
6975a3a
Compare
|
/retest |
|
@saschagrunert @JAORMX now all checks passed. Please could you lgtm this again? Thanks |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ccojocar, JAORMX, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Fix bundle goal into the Makefile for macos.
Which issue(s) this PR fixes:
Does this PR have test?
Special notes for your reviewer:
Does this PR introduce a user-facing change?